mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 13:49:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Move computation out of the ECMAScriptFunctionObject constructor

Browse source 
We were doing way too much computation every time an ESFO was
instantiated. This was particularly sad, since the results of these
computations were identical every time!

This patch adds a new SharedFunctionInstanceData object that gets
shared between all instances of an ESFO instantiated from some kind of
AST FunctionNode.

~5% speedup on Speedometer 2.1 :^)
This commit is contained in:
Andreas Kling 2025-04-08 00:45:27 +02:00 • committed by Andreas Kling
commit 2a9b6f1d97
Notes: github-actions[bot] 2025-04-08 16:53:53 +00:00
7 changed files with 367 additions and 258 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Libraries/LibJS/AST.h
View file

@ -41,6 +41,7 @@ class FunctionDeclaration;
class Identifier;
class MemberExpression;
class VariableDeclaration;
class SharedFunctionInstanceData;
template<class T, class... Args>
static inline NonnullRefPtr<T>
@ -746,25 +747,13 @@ public:
virtual bool has_name() const = 0;
virtual Value instantiate_ordinary_function_expression(VM&, FlyString given_name) const = 0;
virtual ~FunctionNode() { }
RefPtr<SharedFunctionInstanceData> shared_data() const;
void set_shared_data(RefPtr<SharedFunctionInstanceData>) const;
virtual ~FunctionNode();
protected:
FunctionNode(RefPtr<Identifier const> name, ByteString source_text, NonnullRefPtr<Statement const> body, NonnullRefPtr<FunctionParameters const> parameters, i32 function_length, FunctionKind kind, bool is_strict_mode, FunctionParsingInsights parsing_insights, bool is_arrow_function, Vector<FlyString> local_variables_names)
: m_name(move(name))
, m_source_text(move(source_text))
, m_body(move(body))
, m_parameters(move(parameters))
, m_function_length(function_length)
, m_kind(kind)
, m_is_strict_mode(is_strict_mode)
, m_is_arrow_function(is_arrow_function)
, m_parsing_insights(parsing_insights)
, m_local_variables_names(move(local_variables_names))
{
if (m_is_arrow_function)
VERIFY(!parsing_insights.might_need_arguments_object);
}
FunctionNode(RefPtr<Identifier const> name, ByteString source_text, NonnullRefPtr<Statement const> body, NonnullRefPtr<FunctionParameters const> parameters, i32 function_length, FunctionKind kind, bool is_strict_mode, FunctionParsingInsights parsing_insights, bool is_arrow_function, Vector<FlyString> local_variables_names);
void dump(int indent, ByteString const& class_name) const;
RefPtr<Identifier const> m_name { nullptr };
@ -780,6 +769,8 @@ private:
FunctionParsingInsights m_parsing_insights;
Vector<FlyString> m_local_variables_names;
mutable RefPtr<SharedFunctionInstanceData> m_shared_data;
};
class FunctionDeclaration final