LibCore: Implement System::set_close_on_exec

Author: https://github.com/stasoid
Commit: 2abc792938
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3002
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/AtkinsSJ

Libraries/LibIPC/File.cpp

@@ -11,25 +11,11 @@
 
 namespace IPC {
 
-// FIXME: IPC::Files transferred over the wire are always set O_CLOEXEC during decoding.
-//        Perhaps we should add an option to IPC::File to allow the receiver to decide whether to
-//        make it O_CLOEXEC or not. Or an attribute in the .ipc file?
-ErrorOr<void> File::clear_close_on_exec()
-{
-    auto fd_flags = TRY(Core::System::fcntl(m_fd, F_GETFD));
-    fd_flags &= ~FD_CLOEXEC;
-    TRY(Core::System::fcntl(m_fd, F_SETFD, fd_flags));
-    return {};
-}
-
 template<>
 ErrorOr<File> decode(Decoder& decoder)
 {
     auto file = TRY(decoder.files().try_dequeue());
-    auto fd = file.fd();
-
-    auto fd_flags = TRY(Core::System::fcntl(fd, F_GETFD));
-    TRY(Core::System::fcntl(fd, F_SETFD, fd_flags | FD_CLOEXEC));
+    TRY(Core::System::set_close_on_exec(file.fd(), true));
     return file;
 }
 

Libraries/LibIPC/File.h

@@ -63,7 +63,13 @@ public:
         return exchange(m_fd, -1);
     }
 
-    ErrorOr<void> clear_close_on_exec();
+    // FIXME: IPC::Files transferred over the wire are always set O_CLOEXEC during decoding.
+    //        Perhaps we should add an option to IPC::File to allow the receiver to decide whether to
+    //        make it O_CLOEXEC or not. Or an attribute in the .ipc file?
+    ErrorOr<void> clear_close_on_exec()
+    {
+        return Core::System::set_close_on_exec(m_fd, false);
+    }
 
 private:
     explicit File(int fd)

Libraries/LibIPC/FileWindows.cpp

@@ -12,13 +12,6 @@
 
 namespace IPC {
 
-ErrorOr<void> File::clear_close_on_exec()
-{
-    if (!SetHandleInformation(to_handle(m_fd), HANDLE_FLAG_INHERIT, HANDLE_FLAG_INHERIT))
-        return Error::from_windows_error();
-    return {};
-}
-
 template<>
 ErrorOr<File> decode(Decoder& decoder)
 {