From 2af7016a77ea4599c72871368f4e65dd515ec07c Mon Sep 17 00:00:00 2001 From: Callum Law Date: Wed, 6 Aug 2025 15:21:41 +1200 Subject: [PATCH] LibWeb: Rename ValueType::OpenTypeTag to ValueType::OpentypeTag This is the correct capitalization in line with what it is called in the spec "opentype-tag". --- .../LibWeb/CSS/Parser/PropertyParsing.cpp | 2 +- Libraries/LibWeb/CSS/Parser/ValueParsing.cpp | 2 +- Libraries/LibWeb/CSS/ValueType.cpp | 4 +- Libraries/LibWeb/CSS/ValueType.h | 2 +- .../LibWeb/GenerateCSSPropertyID.cpp | 55 +------------------ 5 files changed, 7 insertions(+), 58 deletions(-) diff --git a/Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp b/Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp index ab8f9722f73..df77b40e2e0 100644 --- a/Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp +++ b/Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp @@ -169,7 +169,7 @@ Optional Parser::parse_css_value_for_properties(Readon return parsed.release_value(); if (auto parsed = parse_for_type(ValueType::Ratio); parsed.has_value()) return parsed.release_value(); - if (auto parsed = parse_for_type(ValueType::OpenTypeTag); parsed.has_value()) + if (auto parsed = parse_for_type(ValueType::OpentypeTag); parsed.has_value()) return parsed.release_value(); if (auto parsed = parse_for_type(ValueType::Rect); parsed.has_value()) return parsed.release_value(); diff --git a/Libraries/LibWeb/CSS/Parser/ValueParsing.cpp b/Libraries/LibWeb/CSS/Parser/ValueParsing.cpp index af8ff930da9..78fbd43609e 100644 --- a/Libraries/LibWeb/CSS/Parser/ValueParsing.cpp +++ b/Libraries/LibWeb/CSS/Parser/ValueParsing.cpp @@ -4717,7 +4717,7 @@ RefPtr Parser::parse_value(ValueType value_type, TokenStream value_type_from_string(StringView string) if (string.equals_ignoring_ascii_case("number"sv)) return ValueType::Number; if (string.equals_ignoring_ascii_case("opentype-tag"sv)) - return ValueType::OpenTypeTag; + return ValueType::OpentypeTag; if (string.equals_ignoring_ascii_case("paint"sv)) return ValueType::Paint; if (string.equals_ignoring_ascii_case("percentage"sv)) @@ -103,7 +103,7 @@ StringView value_type_to_string(ValueType value_type) return "Length"sv; case Web::CSS::ValueType::Number: return "Number"sv; - case Web::CSS::ValueType::OpenTypeTag: + case Web::CSS::ValueType::OpentypeTag: return "OpenTypeTag"sv; case Web::CSS::ValueType::Paint: return "Paint"sv; diff --git a/Libraries/LibWeb/CSS/ValueType.h b/Libraries/LibWeb/CSS/ValueType.h index 4a2078bfb61..24791858c10 100644 --- a/Libraries/LibWeb/CSS/ValueType.h +++ b/Libraries/LibWeb/CSS/ValueType.h @@ -30,7 +30,7 @@ enum class ValueType : u8 { Integer, Length, Number, - OpenTypeTag, + OpentypeTag, Paint, Percentage, Position, diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSPropertyID.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSPropertyID.cpp index 32ef497b6a2..ae9341c5f56 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSPropertyID.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSPropertyID.cpp @@ -830,59 +830,8 @@ bool property_accepts_type(PropertyID property_id, ValueType value_type) if (enum_names.contains_slow(type_name)) continue; - if (type_name == "anchor") { - property_generator.appendln(" case ValueType::Anchor:"); - } else if (type_name == "angle") { - property_generator.appendln(" case ValueType::Angle:"); - } else if (type_name == "background-position") { - property_generator.appendln(" case ValueType::BackgroundPosition:"); - } else if (type_name == "basic-shape") { - property_generator.appendln(" case ValueType::BasicShape:"); - } else if (type_name == "color") { - property_generator.appendln(" case ValueType::Color:"); - } else if (type_name == "counter") { - property_generator.appendln(" case ValueType::Counter:"); - } else if (type_name == "custom-ident") { - property_generator.appendln(" case ValueType::CustomIdent:"); - } else if (type_name == "easing-function") { - property_generator.appendln(" case ValueType::EasingFunction:"); - } else if (type_name == "fit-content") { - property_generator.appendln(" case ValueType::FitContent:"); - } else if (type_name == "flex") { - property_generator.appendln(" case ValueType::Flex:"); - } else if (type_name == "frequency") { - property_generator.appendln(" case ValueType::Frequency:"); - } else if (type_name == "image") { - property_generator.appendln(" case ValueType::Image:"); - } else if (type_name == "integer") { - property_generator.appendln(" case ValueType::Integer:"); - } else if (type_name == "length") { - property_generator.appendln(" case ValueType::Length:"); - } else if (type_name == "number") { - property_generator.appendln(" case ValueType::Number:"); - } else if (type_name == "opentype-tag") { - property_generator.appendln(" case ValueType::OpenTypeTag:"); - } else if (type_name == "paint") { - property_generator.appendln(" case ValueType::Paint:"); - } else if (type_name == "percentage") { - property_generator.appendln(" case ValueType::Percentage:"); - } else if (type_name == "position") { - property_generator.appendln(" case ValueType::Position:"); - } else if (type_name == "ratio") { - property_generator.appendln(" case ValueType::Ratio:"); - } else if (type_name == "rect") { - property_generator.appendln(" case ValueType::Rect:"); - } else if (type_name == "resolution") { - property_generator.appendln(" case ValueType::Resolution:"); - } else if (type_name == "string") { - property_generator.appendln(" case ValueType::String:"); - } else if (type_name == "time") { - property_generator.appendln(" case ValueType::Time:"); - } else if (type_name == "url") { - property_generator.appendln(" case ValueType::Url:"); - } else { - VERIFY_NOT_REACHED(); - } + property_generator.set("type_name", title_casify(type_name)); + property_generator.appendln(" case ValueType::@type_name@:"); did_output_accepted_type = true; }