From 2b7b7d4d234b301de299686407ef14eeab92b606 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Sun, 20 Apr 2025 19:06:10 -0400 Subject: [PATCH] Revert "LibWeb: Mark body stream with a TypeError if the request failed" This reverts commit 4d0301d2d2abae9b8e665fd49023eb4054d34eb7. This caused /html/dom/reflection-embedded.html to massively regress. --- Libraries/LibWeb/Fetch/Fetching/Fetching.cpp | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/Libraries/LibWeb/Fetch/Fetching/Fetching.cpp b/Libraries/LibWeb/Fetch/Fetching/Fetching.cpp index 1f2c90543fa..b928089b78e 100644 --- a/Libraries/LibWeb/Fetch/Fetching/Fetching.cpp +++ b/Libraries/LibWeb/Fetch/Fetching/Fetching.cpp @@ -2470,24 +2470,17 @@ WebIDL::ExceptionOr> nonstandard_resource_loader_file_o } else { response->set_type(Infrastructure::Response::Type::Error); response->set_status(status_code.value_or(400)); - auto [body, _] = TRY_OR_IGNORE(extract_body(realm, data)); - response->set_body(body); - + response->set_body(move(body)); auto body_info = response->body_info(); body_info.encoded_size = timing_info.encoded_body_size; body_info.decoded_size = data.size(); response->set_body_info(body_info); - for (auto const& [name, value] : response_headers.headers()) { auto header = Infrastructure::Header::from_latin1_pair(name, value); response->header_list()->append(move(header)); } - // 16.1.2.2. Otherwise, if stream is readable, error stream with a TypeError. - if (body->stream()->is_readable()) - body->stream()->error(JS::TypeError::create(realm, error)); - if (reason_phrase.has_value()) response->set_status_message(MUST(ByteBuffer::copy(reason_phrase.value().bytes()))); }