mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-28 11:49:44 +00:00
LibWeb: Make HTMLCollection and subclasses GC-allocated
This commit is contained in:
parent
4c887bf6c3
commit
2bba97964b
Notes:
sideshowbarker
2024-07-17 07:43:05 +09:00
Author: https://github.com/awesomekling
Commit: 2bba97964b
Pull-request: https://github.com/SerenityOS/serenity/pull/14816
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg ✅
22 changed files with 115 additions and 85 deletions
|
@ -184,7 +184,7 @@ static bool is_form_control(DOM::Element const& element)
|
|||
}
|
||||
|
||||
// https://html.spec.whatwg.org/multipage/forms.html#dom-form-elements
|
||||
NonnullRefPtr<DOM::HTMLCollection> HTMLFormElement::elements() const
|
||||
JS::NonnullGCPtr<DOM::HTMLCollection> HTMLFormElement::elements() const
|
||||
{
|
||||
// FIXME: This should return the same HTMLFormControlsCollection object every time,
|
||||
// but that would cause a reference cycle since HTMLCollection refs the root.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue