mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 12:49:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Consume user activation when choosing a Navigable

Browse source 
Corresponds to https://github.com/whatwg/html/pull/10547
This commit is contained in:
Sam Atkins 2024-11-25 12:37:00 +00:00 • committed by Andreas Kling
commit 2c7e730726
Notes: github-actions[bot] 2024-11-26 10:00:48 +00:00
1 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Libraries/LibWeb/HTML/Navigable.cpp
View file

@ -420,13 +420,16 @@ Navigable::ChosenNavigable Navigable::choose_a_navigable(StringView name, Tokeni
// --> If the user agent has been configured such that in this instance it will create a new top-level traversable // --> If the user agent has been configured such that in this instance it will create a new top-level traversable
else if (true) { // FIXME: When is this the case? else if (true) { // FIXME: When is this the case?
// 1. Set windowType to "new and unrestricted". // 1. Consume user activation of currentNavigable's active window.
active_window()->consume_user_activation();
// 2. Set windowType to "new and unrestricted".
window_type = WindowType::NewAndUnrestricted; window_type = WindowType::NewAndUnrestricted;
// 2. Let currentDocument be currentNavigable's active document. // 3. Let currentDocument be currentNavigable's active document.
auto current_document = active_document(); auto current_document = active_document();
// 3. If currentDocument's opener policy's value is "same-origin" or "same-origin-plus-COEP", // 4. If currentDocument's opener policy's value is "same-origin" or "same-origin-plus-COEP",
// and currentDocument's origin is not same origin with currentDocument's relevant settings object's top-level origin, then: // and currentDocument's origin is not same origin with currentDocument's relevant settings object's top-level origin, then:
if ((current_document->opener_policy().value == OpenerPolicyValue::SameOrigin || current_document->opener_policy().value == OpenerPolicyValue::SameOriginPlusCOEP) if ((current_document->opener_policy().value == OpenerPolicyValue::SameOrigin || current_document->opener_policy().value == OpenerPolicyValue::SameOriginPlusCOEP)
&& !current_document->origin().is_same_origin(relevant_settings_object(*current_document).top_level_origin)) { && !current_document->origin().is_same_origin(relevant_settings_object(*current_document).top_level_origin)) {
@ -443,13 +446,13 @@ Navigable::ChosenNavigable Navigable::choose_a_navigable(StringView name, Tokeni
// NOTE: In the presence of an opener policy, // NOTE: In the presence of an opener policy,
// nested documents that are cross-origin with their top-level browsing context's active document always set noopener to true. // nested documents that are cross-origin with their top-level browsing context's active document always set noopener to true.
// 4. Let chosen be null. // 5. Let chosen be null.
chosen = nullptr; chosen = nullptr;
// 5. Let targetName be the empty string. // 6. Let targetName be the empty string.
String target_name; String target_name;
// 6. If name is not an ASCII case-insensitive match for "_blank", then set targetName to name. // 7. If name is not an ASCII case-insensitive match for "_blank", then set targetName to name.
if (!Infra::is_ascii_case_insensitive_match(name, "_blank"sv)) if (!Infra::is_ascii_case_insensitive_match(name, "_blank"sv))
target_name = MUST(String::from_utf8(name)); target_name = MUST(String::from_utf8(name));
@ -463,12 +466,12 @@ Navigable::ChosenNavigable Navigable::choose_a_navigable(StringView name, Tokeni
}; };
auto create_new_traversable = GC::create_function(heap(), move(create_new_traversable_closure)); auto create_new_traversable = GC::create_function(heap(), move(create_new_traversable_closure));
// 7. If noopener is true, then set chosen to the result of creating a new top-level traversable given null and targetName. // 8. If noopener is true, then set chosen to the result of creating a new top-level traversable given null and targetName.
if (no_opener == TokenizedFeature::NoOpener::Yes) { if (no_opener == TokenizedFeature::NoOpener::Yes) {
chosen = create_new_traversable->function()(nullptr); chosen = create_new_traversable->function()(nullptr);
} }
// 8. Otherwise: // 9. Otherwise:
else { else {
// 1. Set chosen to the result of creating a new top-level traversable given currentNavigable's active browsing context and targetName. // 1. Set chosen to the result of creating a new top-level traversable given currentNavigable's active browsing context and targetName.
chosen = create_new_traversable->function()(active_browsing_context()); chosen = create_new_traversable->function()(active_browsing_context());
@ -477,7 +480,7 @@ Navigable::ChosenNavigable Navigable::choose_a_navigable(StringView name, Tokeni
// then set chosen's active browsing context's one permitted sandboxed navigator to currentNavigable's active browsing context. // then set chosen's active browsing context's one permitted sandboxed navigator to currentNavigable's active browsing context.
} }
// FIXME: 5. If sandboxingFlagSet's sandbox propagates to auxiliary browsing contexts flag is set, // FIXME: 10. If sandboxingFlagSet's sandbox propagates to auxiliary browsing contexts flag is set,
// then all the flags that are set in sandboxingFlagSet must be set in chosen's active browsing context's popup sandboxing flag set. // then all the flags that are set in sandboxingFlagSet must be set in chosen's active browsing context's popup sandboxing flag set.
// Our BrowsingContexts do not have SandboxingFlagSets yet, only documents do // Our BrowsingContexts do not have SandboxingFlagSets yet, only documents do
} }