mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-11 20:16:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Generate an enum for generated pseudo-elements

Browse source
This commit is contained in:
Sam Atkins 2025-03-19 15:52:33 +00:00
commit 2c86fd539d
Notes: github-actions[bot] 2025-03-24 09:51:16 +00:00
4 changed files with 80 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/Layout/Node.cpp
View file

@ -1155,13 +1155,13 @@ DOM::Node* Node::dom_node()
DOM::Element const* Node::pseudo_element_generator() const
{
VERIFY(m_generated_for != GeneratedFor::NotGenerated);
VERIFY(m_generated_for.has_value());
return m_pseudo_element_generator.ptr();
}
DOM::Element* Node::pseudo_element_generator()
{
VERIFY(m_generated_for != GeneratedFor::NotGenerated);
VERIFY(m_generated_for.has_value());
return m_pseudo_element_generator.ptr();
}

15
Libraries/LibWeb/Layout/Node.h
View file

@ -45,15 +45,10 @@ public:
DOM::Element const* pseudo_element_generator() const;
DOM::Element* pseudo_element_generator();
enum class GeneratedFor {
NotGenerated,
PseudoBefore,
PseudoAfter
};
bool is_generated() const { return m_generated_for != GeneratedFor::NotGenerated; }
bool is_generated_for_before_pseudo_element() const { return m_generated_for == GeneratedFor::PseudoBefore; }
bool is_generated_for_after_pseudo_element() const { return m_generated_for == GeneratedFor::PseudoAfter; }
void set_generated_for(GeneratedFor type, DOM::Element& element)
bool is_generated() const { return m_generated_for.has_value(); }
bool is_generated_for_before_pseudo_element() const { return m_generated_for == CSS::GeneratedPseudoElement::Before; }
bool is_generated_for_after_pseudo_element() const { return m_generated_for == CSS::GeneratedPseudoElement::After; }
void set_generated_for(CSS::GeneratedPseudoElement type, DOM::Element& element)
{
m_generated_for = type;
m_pseudo_element_generator = &element;
@ -213,7 +208,7 @@ private:
bool m_has_been_wrapped_in_table_wrapper { false };
GeneratedFor m_generated_for { GeneratedFor::NotGenerated };
Optional<CSS::GeneratedPseudoElement> m_generated_for {};
u32 m_initial_quote_nesting_level { 0 };
};

10
Libraries/LibWeb/Layout/TreeBuilder.cpp
View file

@ -225,15 +225,7 @@ void TreeBuilder::create_pseudo_element_if_needed(DOM::Element& element, CSS::Ps
pseudo_element_node->append_child(*list_item_marker);
}
auto generated_for = Node::GeneratedFor::NotGenerated;
if (pseudo_element == CSS::PseudoElement::Before) {
generated_for = Node::GeneratedFor::PseudoBefore;
} else if (pseudo_element == CSS::PseudoElement::After) {
generated_for = Node::GeneratedFor::PseudoAfter;
} else {
VERIFY_NOT_REACHED();
}
auto generated_for = CSS::to_generated_pseudo_element(pseudo_element).release_value();
pseudo_element_node->set_generated_for(generated_for, element);
pseudo_element_node->set_initial_quote_nesting_level(initial_quote_nesting_level);