mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 09:09:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't attempt to set selection if control has no selectable text

Browse source
This commit is contained in:
Tim Ledbetter 2024-09-08 23:59:31 +01:00 • committed by Jelle Raaijmakers
commit 2c8fb49578
Notes: github-actions[bot] 2024-09-09 09:05:03 +00:00
4 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/HTML/HTMLInputElement-select-crash.txt Normal file
View file

@ -0,0 +1 @@
PASS (didn't crash)

11
Tests/LibWeb/Text/input/HTML/HTMLInputElement-select-crash.html Normal file
View file

@ -0,0 +1,11 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
const inputElement = document.createElement("input");
inputElement.type = "color";
inputElement.value = "#000000";
inputElement.select();
println("PASS (didn't crash)");
});
</script>

3
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -2365,6 +2365,9 @@ HTMLInputElement::ValueAttributeMode HTMLInputElement::value_attribute_mode() co
void HTMLInputElement::selection_was_changed(size_t selection_start, size_t selection_end) void HTMLInputElement::selection_was_changed(size_t selection_start, size_t selection_end)
{ {
if (!m_text_node)
return;
document().set_cursor_position(DOM::Position::create(realm(), *m_text_node, selection_end)); document().set_cursor_position(DOM::Position::create(realm(), *m_text_node, selection_end));
if (auto selection = document().get_selection()) if (auto selection = document().get_selection())

3
Userland/Libraries/LibWeb/HTML/HTMLTextAreaElement.cpp
View file

@ -463,6 +463,9 @@ void HTMLTextAreaElement::queue_firing_input_event()
void HTMLTextAreaElement::selection_was_changed(size_t selection_start, size_t selection_end) void HTMLTextAreaElement::selection_was_changed(size_t selection_start, size_t selection_end)
{ {
if (!m_text_node)
return;
document().set_cursor_position(DOM::Position::create(realm(), *m_text_node, selection_end)); document().set_cursor_position(DOM::Position::create(realm(), *m_text_node, selection_end));
if (auto selection = document().get_selection()) if (auto selection = document().get_selection())