mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 11:49:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Invalidate text-decoration-thickness as paint-only property

Browse source 
Fixes underinvalidation caused by resolving text-decoration-thickness
during layout commit, while this property can be invalidated
independently of layout.
This commit is contained in:
Aliaksandr Kalenik 2025-03-16 18:05:38 +01:00 • committed by Alexander Kalenik
commit 2e256d2eac
Notes: github-actions[bot] 2025-03-16 21:26:18 +00:00
4 changed files with 24 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibWeb/Layout/LayoutState.cpp
View file

@ -363,17 +363,6 @@ void LayoutState::commit(Box& root)
for (auto* text_node : text_nodes) {
text_node->add_paintable(text_node->create_paintable());
auto* paintable = text_node->first_paintable();
auto const& font = text_node->first_available_font();
auto const glyph_height = CSSPixels::nearest_value_for(font.pixel_size());
auto const css_line_thickness = [&] {
auto computed_thickness = text_node->computed_values().text_decoration_thickness().resolved(*text_node, CSS::Length(1, CSS::Length::Type::Em).to_px(*text_node));
if (computed_thickness.is_auto())
return max(glyph_height.scaled(0.1), 1);
return computed_thickness.to_px(*text_node);
}();
auto& text_paintable = static_cast<Painting::TextPaintable&>(*paintable);
text_paintable.set_text_decoration_thickness(css_line_thickness);
}
build_paint_tree(root);