mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-26 14:28:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Update cloning steps to current spec algorithms

Browse source 
Reflects the changes in https://github.com/whatwg/html/pull/10859

I've also added missing calls to the Base::cloned() method, and modified
a couple of spec links to point to the multipage version.

I took the liberty to fix a spec typo, and submitted a PR for it:
https://github.com/whatwg/html/pull/10892
This commit is contained in:
Sam Atkins 2025-01-05 15:46:37 +00:00 • committed by Tim Ledbetter
parent 172d5f6987
commit 2e96ba11e4
Notes: github-actions[bot] 2025-01-05 21:12:56 +00:00
4 changed files with 26 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Libraries/LibWeb/HTML/HTMLTemplateElement.cpp
View file

@ -46,20 +46,24 @@ void HTMLTemplateElement::adopted_from(DOM::Document&)
}
// https://html.spec.whatwg.org/multipage/scripting.html#the-template-element:concept-node-clone-ext
WebIDL::ExceptionOr<void> HTMLTemplateElement::cloned(Node& copy, bool clone_children)
WebIDL::ExceptionOr<void> HTMLTemplateElement::cloned(Node& copy, bool subtree)
{
// 1. If the clone children flag is not set in the calling clone algorithm, return.
if (!clone_children)
TRY(Base::cloned(copy, subtree));
// The cloning steps for template elements given node, copy, and subtree are:
// 1. If subtree is false, then return.
if (!subtree)
return {};
// 2. Let copied contents be the result of cloning all the children of node's template contents,
// with document set to copy's template contents's node document, and with the clone children flag set.
// 3. Append copied contents to copy's template contents.
auto& template_clone = verify_cast<HTMLTemplateElement>(copy);
// 2. For each child of node's template contents's children, in tree order:
// clone a node given child with document set to copy's template contents's node document,
// subtree set to true, and parent set to copy's template contents.
auto& template_copy = verify_cast<HTMLTemplateElement>(copy);
for (auto child = content()->first_child(); child; child = child->next_sibling()) {
auto cloned_child = TRY(child->clone_node(&template_clone.content()->document(), true));
TRY(template_clone.content()->append_child(cloned_child));
TRY(child->clone_node(&template_copy.content()->document(), true, template_copy.content()));
}
return {};
}