mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Do not ignore self-start/self-end alignment in flex layout

Browse source 
This makes these values the same as `start` and `end`. While this is not
entirely correct, it is better than centering which is what we did
previously.

This fixes misaligned images on https://nos.nl
This commit is contained in:
Milo van der Tier 2024-12-01 16:07:11 +01:00 • committed by Andreas Kling
commit 2ee7e555f2
Notes: github-actions[bot] 2024-12-02 23:18:43 +00:00
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -1499,11 +1499,15 @@ void FlexFormattingContext::align_all_flex_items_along_the_cross_axis()
// Fallthrough
case CSS::AlignItems::Start:
case CSS::AlignItems::FlexStart:
case CSS::AlignItems::SelfStart:
case CSS::AlignItems::Stretch:
// FIXME: 'start', 'flex-start' and 'self-start' have subtly different behavior.
// The same goes for the end values.
item.cross_offset = -half_line_size + item.margins.cross_before + item.borders.cross_before + item.padding.cross_before;
break;
case CSS::AlignItems::End:
case CSS::AlignItems::FlexEnd:
case CSS::AlignItems::SelfEnd:
item.cross_offset = half_line_size - item.cross_size.value() - item.margins.cross_after - item.borders.cross_after - item.padding.cross_after;
break;
case CSS::AlignItems::Center: