mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-29 04:09:13 +00:00
Ladybird/Everywhere: Ensure that Qt objects are created with parents
This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
This commit is contained in:
parent
f9af2832c8
commit
2ff37d7e13
Notes:
sideshowbarker
2024-07-17 22:41:14 +09:00
Author: https://github.com/ADKaster
Commit: 2ff37d7e13
Pull-request: https://github.com/SerenityOS/serenity/pull/16583
Reviewed-by: https://github.com/awesomekling ✅
Reviewed-by: https://github.com/linusg
7 changed files with 41 additions and 41 deletions
|
@ -28,9 +28,8 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
|
|||
args_parser.add_positional_argument(url, "URL to open", "url", Core::ArgsParser::Required::No);
|
||||
args_parser.parse(arguments);
|
||||
|
||||
s_settings = new Browser::Settings();
|
||||
|
||||
BrowserWindow window;
|
||||
s_settings = new Browser::Settings(&window);
|
||||
window.setWindowTitle("Ladybird");
|
||||
window.resize(800, 600);
|
||||
window.show();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue