mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-08-12 19:19:30 +00:00
LibJS: Don't return empty value from PromiseReactionJob::call(), for now
This commit is contained in:
parent
fb85fd4867
commit
2ffb30a996
Notes:
sideshowbarker
2024-07-18 02:21:54 +09:00
Author: https://github.com/linusg
Commit: 2ffb30a996
Pull-request: https://github.com/SerenityOS/serenity/pull/10479
Reviewed-by: https://github.com/IdanHo ✅
1 changed files with 3 additions and 1 deletions
|
@ -53,7 +53,9 @@ Value PromiseReactionJob::call()
|
|||
|
||||
if (!promise_capability.has_value()) {
|
||||
dbgln_if(PROMISE_DEBUG, "[PromiseReactionJob @ {}]: Reaction has no PromiseCapability, returning empty value", this);
|
||||
return {};
|
||||
// TODO: This can't return an empty value at the moment, because the implicit conversion to Completion would fail.
|
||||
// Change it back when this is using completions (`return normal_completion({})`)
|
||||
return js_undefined();
|
||||
}
|
||||
|
||||
if (vm.exception()) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue