mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-03 14:50:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Do not spin the event loop on processing iframe attributes

Browse source 
Partially reverting a3149c1ce9

Spinning the event loop was causing a crash on:

https://wpt.live/url/percent-encoding.window.html

As it was turning what is meant to be a synchronous operation into an
asynchronous one.

The sequence demonstrated by the reproducing test is as follows:
  * A src attribute is changed for the iframe
  * process_the_iframe_attributes entered with valid content navigable
  * Event loop is spun, allowing the queued iframe removal to execute
  * process_the_iframe_attributes continues with null content navigable
  * 💥
This commit is contained in:
Shannon Booth 2024-10-07 16:44:16 +13:00 • committed by Alexander Kalenik
commit 30377e6e35
Notes: github-actions[bot] 2024-10-07 13:11:44 +00:00
3 changed files with 21 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Tests/LibWeb/Text/input/iframe-removed-asyncronously.html Normal file
View file

@ -0,0 +1,20 @@
<body>
</body>
<script src="include.js"></script>
<script>
asyncTest(done => {
let frame = document.body.appendChild(document.createElement("iframe"));
setTimeout(() => {
frame.remove();
setTimeout(() => {
println("PASS! (Didn't crash)");
done();
}, 0);
}, 0);
frame.src = `../data/iframe-with-border-radius-svg.html`;
})
</script>