mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-02 06:09:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Implement "delete the selection" for the editing API

Browse source
This commit is contained in:
Jelle Raaijmakers 2024-12-04 23:08:46 +01:00 • committed by Jelle Raaijmakers
commit 30ec8c1d4d
Notes: github-actions[bot] 2024-12-10 13:55:13 +00:00
3 changed files with 681 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Libraries/LibWeb/Editing/Commands.cpp
View file

@ -367,8 +367,8 @@ bool command_delete_action(DOM::Document& document, String const&)
// 18. Call extend(node, offset) on the context object's selection.
MUST(selection.extend(*node, offset));
// FIXME: 19. Delete the selection, with direction "backward".
delete_the_selection(selection);
// 19. Delete the selection, with direction "backward".
delete_the_selection(selection, true, true, Selection::Direction::Backwards);
// 20. Return true.
return true;
@ -669,28 +669,12 @@ bool command_insert_paragraph_action(DOM::Document& document, String const&)
// 32. If container has no visible children, call createElement("br") on the context object, and append the result
// as the last child of container.
bool has_visible_child = false;
container->for_each_child([&has_visible_child](GC::Ref<DOM::Node> child) {
if (is_visible_node(child)) {
has_visible_child = true;
return IterationDecision::Break;
}
return IterationDecision::Continue;
});
if (!has_visible_child)
if (!has_visible_children(*container))
MUST(container->append_child(MUST(DOM::create_element(document, HTML::TagNames::br, Namespace::HTML))));
// 33. If new container has no visible children, call createElement("br") on the context object, and append the
// result as the last child of new container.
has_visible_child = false;
new_container->for_each_child([&has_visible_child](GC::Ref<DOM::Node> child) {
if (is_visible_node(child)) {
has_visible_child = true;
return IterationDecision::Break;
}
return IterationDecision::Continue;
});
if (!has_visible_child)
if (!has_visible_children(*new_container))
MUST(new_container->append_child(MUST(DOM::create_element(document, HTML::TagNames::br, Namespace::HTML))));
// 34. Call collapse(new container, 0) on the context object's selection.