LibWeb: Fill-in some fixmes around sandboxing flag sets

...Including a couple of steps in
obtain_a_browsing_context_to_use_for_a_navigation_response() which
didn't have FIXMEs.

No apparent changes on WPT.
This commit is contained in:
Sam Atkins 2024-11-25 17:06:54 +00:00 committed by Andreas Kling
parent 2c7e730726
commit 310cdc35f0
Notes: github-actions[bot] 2024-11-26 10:00:42 +00:00
5 changed files with 28 additions and 6 deletions

View file

@ -163,7 +163,7 @@ WebIDL::ExceptionOr<BrowsingContext::BrowsingContextAndDocument> BrowsingContext
browsing_context->m_virtual_browsing_context_group_id = creator->browsing_context()->top_level_browsing_context()->m_virtual_browsing_context_group_id;
}
// 6. Let sandboxFlags be the result of determining the creation sandboxing flags given browsingContext and embedder.
// FIXME: 6. Let sandboxFlags be the result of determining the creation sandboxing flags given browsingContext and embedder.
SandboxingFlagSet sandbox_flags = {};
// 7. Let origin be the result of determining the origin given about:blank, sandboxFlags, and creatorOrigin.
@ -236,7 +236,8 @@ WebIDL::ExceptionOr<BrowsingContext::BrowsingContextAndDocument> BrowsingContext
// FIXME: permissions policy: permissionsPolicy
// FIXME: active sandboxing flag set: sandboxFlags
// active sandboxing flag set: sandboxFlags
document->set_active_sandboxing_flag_set(sandbox_flags);
// load timing info: loadTimingInfo
document->set_load_timing_info(load_timing_info);