From 314f4ff0da5a62dc75068d62ca072689ef977807 Mon Sep 17 00:00:00 2001 From: Jelle Raaijmakers Date: Mon, 3 Feb 2025 14:42:44 +0100 Subject: [PATCH] LibWeb: Prevent double page title update in DOM::Document This ad-hoc code informs the client of a potentially changed page title. But because we always update the title element (either the SVG or HTML title) the client was already informed, causing the code to run twice. --- Libraries/LibWeb/DOM/Document.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/Libraries/LibWeb/DOM/Document.cpp b/Libraries/LibWeb/DOM/Document.cpp index 2e4df27997c..68deb46991c 100644 --- a/Libraries/LibWeb/DOM/Document.cpp +++ b/Libraries/LibWeb/DOM/Document.cpp @@ -1029,9 +1029,6 @@ WebIDL::ExceptionOr Document::set_title(String const& title) return {}; } - if (browsing_context() == &page().top_level_browsing_context()) - page().client().page_did_change_title(title.to_byte_string()); - return {}; }