mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-09 09:39:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Avoid naming conflict between Object's and Error's is_error

Browse source 
Object defines an is_error virtual method to be overridden by Error for
fast-is. This is the same name as the Error.isError constructor method.
Rename the former to avoid conflicts, as GCC 15 just started warning on
this.
This commit is contained in:
Timothy Flynn 2025-04-26 08:07:22 -04:00 • committed by Andrew Kaster
commit 317cf65eb0
Notes: github-actions[bot] 2025-04-26 15:05:50 +00:00
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/Error.h
View file

@ -47,14 +47,14 @@ protected:
explicit Error(Object& prototype);
private:
virtual bool is_error() const final { return true; }
virtual bool is_error_object() const final { return true; }
void populate_stack();
Vector<TracebackFrame, 32> m_traceback;
};
template<>
inline bool Object::fast_is<Error>() const { return is_error(); }
inline bool Object::fast_is<Error>() const { return is_error_object(); }
// NOTE: Making these inherit from Error is not required by the spec but
// our way of implementing the [[ErrorData]] internal slot, which is

2
Libraries/LibJS/Runtime/Object.h
View file

@ -197,7 +197,7 @@ public:
virtual bool is_function() const { return false; }
virtual bool is_promise() const { return false; }
virtual bool is_error() const { return false; }
virtual bool is_error_object() const { return false; }
virtual bool is_date() const { return false; }
virtual bool is_number_object() const { return false; }
virtual bool is_boolean_object() const { return false; }