mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-15 05:52:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Fire auxclick event on middle click

Browse source 
Previously, no event was fired on middle click. This change also allows
the UI to open a link in a new tab on middle click.
This commit is contained in:
Tim Ledbetter 2024-06-21 22:00:19 +01:00 • committed by Andreas Kling
commit 31d7fa2442
Notes: sideshowbarker 2024-07-17 21:16:31 +09:00
3 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/UIEvents/auxevent.txt Normal file
View file

@ -0,0 +1 @@
auxclick event fired

22
Tests/LibWeb/Text/input/UIEvents/auxevent.html Normal file
View file

@ -0,0 +1,22 @@
<!DOCTYPE html>
<style>
body {
margin: 0px;
padding: 5px;
width: 200px;
height: 200px;
}
</style>
<script src="../include.js"></script>
<script>
asyncTest(done => {
document.body.onauxclick = () => {
println("auxclick event fired");
done();
};
window.onload = () => {
internals.middleClick(10, 10);
};
});
</script>

2
Userland/Libraries/LibWeb/Page/EventHandler.cpp
View file

@ -278,6 +278,8 @@ bool EventHandler::handle_mouseup(CSSPixelPoint viewport_position, CSSPixelPoint
if (node.ptr() == m_mousedown_target) { if (node.ptr() == m_mousedown_target) {
if (button == UIEvents::MouseButton::Primary) { if (button == UIEvents::MouseButton::Primary) {
run_activation_behavior = node->dispatch_event(UIEvents::MouseEvent::create_from_platform_event(node->realm(), UIEvents::EventNames::click, screen_position, page_offset, client_offset, offset, {}, 1, button, modifiers).release_value_but_fixme_should_propagate_errors()); run_activation_behavior = node->dispatch_event(UIEvents::MouseEvent::create_from_platform_event(node->realm(), UIEvents::EventNames::click, screen_position, page_offset, client_offset, offset, {}, 1, button, modifiers).release_value_but_fixme_should_propagate_errors());
} else if (button == UIEvents::MouseButton::Middle) {
run_activation_behavior = node->dispatch_event(UIEvents::MouseEvent::create_from_platform_event(node->realm(), UIEvents::EventNames::auxclick, screen_position, page_offset, client_offset, offset, {}, 1, button, modifiers).release_value_but_fixme_should_propagate_errors());
} else if (button == UIEvents::MouseButton::Secondary) { } else if (button == UIEvents::MouseButton::Secondary) {
// Allow the user to bypass custom context menus by holding shift, like Firefox. // Allow the user to bypass custom context menus by holding shift, like Firefox.
if ((modifiers & UIEvents::Mod_Shift) == 0) if ((modifiers & UIEvents::Mod_Shift) == 0)