From 328ad9a2f03105782779143d40155111b2d7d30f Mon Sep 17 00:00:00 2001
From: Matthew Olsson <matthewcolsson@gmail.com>
Date: Fri, 29 Mar 2024 18:40:37 +0000
Subject: [PATCH] LibWeb: Use InternalAnimationTimeline in existing tests

---
 .../animation-properties/currentTime.txt            |  1 +
 .../animation-properties/currentTime.html           | 13 ++++++-------
 .../animation-properties/finished.html              | 11 +++++------
 .../animation-properties/replaceState.html          |  2 +-
 4 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/Tests/LibWeb/Text/expected/WebAnimations/animation-properties/currentTime.txt b/Tests/LibWeb/Text/expected/WebAnimations/animation-properties/currentTime.txt
index 860348e8918..02c997d6151 100644
--- a/Tests/LibWeb/Text/expected/WebAnimations/animation-properties/currentTime.txt
+++ b/Tests/LibWeb/Text/expected/WebAnimations/animation-properties/currentTime.txt
@@ -1,5 +1,6 @@
    Animation with no timeline has null currentTime: true
 Animation that hasn't been played has null currentTime: true
 Played animation has a currentTime of 0: true
+Animation time after 100ms is correct
 New animation has not started animating: true
 Animation with currentTime set to end is finished: true
diff --git a/Tests/LibWeb/Text/input/WebAnimations/animation-properties/currentTime.html b/Tests/LibWeb/Text/input/WebAnimations/animation-properties/currentTime.html
index 49d54982d98..811c84b46d0 100644
--- a/Tests/LibWeb/Text/input/WebAnimations/animation-properties/currentTime.html
+++ b/Tests/LibWeb/Text/input/WebAnimations/animation-properties/currentTime.html
@@ -2,7 +2,7 @@
 <div id="foo"></div>
 <script src="../../include.js"></script>
 <script>
-    promiseTest(async () => {
+    test(() => {
         const foo = document.getElementById("foo");
 
         let animation = new Animation(null, null);
@@ -11,14 +11,13 @@
         animation = new Animation(new KeyframeEffect(foo, []));
         println(`Animation that hasn't been played has null currentTime: ${animation.currentTime === null}`);
 
-        animation = foo.animate({ color: "red" }, { duration: 1000 });
+        const timeline = internals.createInternalAnimationTimeline();
+        animation = foo.animate({ color: "red" }, { duration: 1000, timeline });
         println(`Played animation has a currentTime of 0: ${animation.currentTime === 0}`);
 
-        await timeout(100);
-
-        // FIXME: Figure out how to consistently test timings
-        // if (animation.currentTime > 95 && animation.currentTime < 105)
-        //     println("Animation time after 100ms is correct");
+        timeline.setTime(100);
+        if (animation.currentTime === 100)
+            println("Animation time after 100ms is correct");
 
         animation = foo.animate({ opacity: [0, 1] }, { duration: 1000 });
         println(`New animation has not started animating: ${getComputedStyle(foo).opacity === "0"}`);
diff --git a/Tests/LibWeb/Text/input/WebAnimations/animation-properties/finished.html b/Tests/LibWeb/Text/input/WebAnimations/animation-properties/finished.html
index 7b4bf96a71e..8a88b99a07a 100644
--- a/Tests/LibWeb/Text/input/WebAnimations/animation-properties/finished.html
+++ b/Tests/LibWeb/Text/input/WebAnimations/animation-properties/finished.html
@@ -4,15 +4,14 @@
 <script>
     promiseTest(async () => {
         const foo = document.getElementById("foo");
-        let animation = foo.animate({ opacity: [0, 1] }, { duration: 100 });
+        const timeline = internals.createInternalAnimationTimeline();
+        let animation = foo.animate({ opacity: [0, 1] }, { duration: 100, timeline });
         let finishedPromise = animation.finished;
 
-        // FIXME: Figure out how to consistently test timings
-        // const currentTime = performance.now();
+        timeline.setTime(100);
+
+        // This should finish. If not, the test will time out and result in a failure
         await finishedPromise;
-        // const elapsedTime = performance.now() - currentTime;
-        // if (elapsedTime > 95 && elapsedTime < 105)
-        //     println("Animation time after 100ms is correct")
 
         println(`finished promise remains after finishing: ${Object.is(finishedPromise, animation.finished)}`);
 
diff --git a/Tests/LibWeb/Text/input/WebAnimations/animation-properties/replaceState.html b/Tests/LibWeb/Text/input/WebAnimations/animation-properties/replaceState.html
index b1bf1e05a03..01d29ff7aea 100644
--- a/Tests/LibWeb/Text/input/WebAnimations/animation-properties/replaceState.html
+++ b/Tests/LibWeb/Text/input/WebAnimations/animation-properties/replaceState.html
@@ -2,7 +2,7 @@
 <div id="foo"></div>
 <script src="../../include.js"></script>
 <script>
-    // Note: The "persisted" state will be tested in the Animation.persist() test
+    // Note: The "persisted" state is tested in the Animation.persist() test
 
     promiseTest(async () => {
         const foo = document.getElementById("foo");