mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-05 08:31:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Treat x resolution unit separately from dppx

Browse source 
Tests show that we need to preserve whether x or dppx units were used,
so the simplest way is to treat them separately.
This commit is contained in:
Sam Atkins 2025-05-16 20:15:07 +01:00 • committed by Tim Ledbetter
parent 443f9e5afb
commit 338282f74d
Notes: github-actions[bot] 2025-05-17 06:54:37 +00:00
3 changed files with 14 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibWeb/CSS/Resolution.cpp
View file

@ -35,6 +35,7 @@ double Resolution::to_dots_per_pixel() const
case Type::Dpcm:
return m_value / (96.0 / 2.54); // 1cm = 96px/2.54
case Type::Dppx:
case Type::X:
return m_value;
}
VERIFY_NOT_REACHED();
@ -49,19 +50,22 @@ StringView Resolution::unit_name() const
return "dpcm"sv;
case Type::Dppx:
return "dppx"sv;
case Type::X:
return "x"sv;
}
VERIFY_NOT_REACHED();
}
Optional<Resolution::Type> Resolution::unit_from_name(StringView name)
{
if (name.equals_ignoring_ascii_case("dpi"sv)) {
if (name.equals_ignoring_ascii_case("dpi"sv))
return Type::Dpi;
} else if (name.equals_ignoring_ascii_case("dpcm"sv)) {
if (name.equals_ignoring_ascii_case("dpcm"sv))
return Type::Dpcm;
} else if (name.equals_ignoring_ascii_case("dppx"sv) || name.equals_ignoring_ascii_case("x"sv)) {
if (name.equals_ignoring_ascii_case("dppx"sv))
return Type::Dppx;
}
if (name.equals_ignoring_ascii_case("x"sv))
return Type::X;
return {};
}