mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-11 10:41:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibCore: Port Process to Windows

Browse source 
Windows doesn't have a concept of zombie children, hence:
* `disown` not needed
* we need a process handle because otherwise if the process have ended
  by the time `wait_for_termination` is called
  its pid may be reassigned to other process
This commit is contained in:
stasoid 2024-11-17 22:07:43 +05:00 • committed by Andrew Kaster
commit 3468a83e45
Notes: github-actions[bot] 2024-11-19 22:28:29 +00:00
3 changed files with 200 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

33
Libraries/LibCore/Process.h
View file

@ -53,23 +53,9 @@ public:
No
};
Process(Process&& other)
: m_pid(exchange(other.m_pid, 0))
, m_should_disown(exchange(other.m_should_disown, false))
{
}
Process& operator=(Process&& other)
{
m_pid = exchange(other.m_pid, 0);
m_should_disown = exchange(other.m_should_disown, false);
return *this;
}
~Process()
{
(void)disown();
}
Process(Process&& other);
Process& operator=(Process&& other);
~Process();
static ErrorOr<Process> spawn(ProcessSpawnOptions const& options);
static Process current();
@ -87,14 +73,17 @@ public:
static void wait_for_debugger_and_break();
static ErrorOr<bool> is_being_debugged();
pid_t pid() const { return m_pid; }
pid_t pid() const;
#ifndef AK_OS_WINDOWS
ErrorOr<void> disown();
#endif
// FIXME: Make it return an exit code.
ErrorOr<bool> wait_for_termination();
private:
#ifndef AK_OS_WINDOWS
Process(pid_t pid = -1)
: m_pid(pid)
, m_should_disown(true)
@ -103,6 +92,14 @@ private:
pid_t m_pid;
bool m_should_disown;
#else
Process(void* handle = 0)
: m_handle(handle)
{
}
void* m_handle;
#endif
};
}