mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-15 21:41:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Don't drop messages received before MessagePort is enabled
Some checks are pending
CI / macOS, arm64, Sanitizer_CI, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers_CI, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer_CI, GNU (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer_CI, Clang (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
This change implements following behavior defined in the spec:
https://html.spec.whatwg.org/multipage/web-messaging.html#examples-5
> The start() method, whether called explicitly or implicitly (by
setting onmessage), starts the flow of messages: messages posted on
message ports are initially paused, so that they don't get dropped on
the floor before the script has had a chance to set up its handlers.

Now we don't read bytes from the underlying transport socket until the
message port transitions to the enabled state. This required the
following places to explicitly enable the message port, because now,
when it actually matters, we must do so, or otherwise sent messages will
get stuck:
- `onmessage` attribute setter in DedicatedWorkerGlobalScope, because
  it implicitly sets the onmessage handler for the worker's underlying
  port.
- Stream API operations where the message port enabling steps were
  previously marked as FIXMEs.
This commit is contained in:
Aliaksandr Kalenik 2025-06-07 23:57:17 +02:00 • committed by Alexander Kalenik
parent d8c86a2b09
commit 346c083d58
Notes: github-actions[bot] 2025-06-08 16:27:20 +00:00
7 changed files with 64 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Libraries/LibWeb/HTML/MessagePort.cpp
View file

@ -135,7 +135,8 @@ WebIDL::ExceptionOr<void> MessagePort::transfer_receiving_steps(HTML::TransferDa
m_transport = make<IPC::Transport>(MUST(Core::LocalSocket::adopt_fd(fd.take_fd())));
m_transport->set_up_read_hook([strong_this = GC::make_root(this)]() {
strong_this->read_from_transport();
if (strong_this->m_enabled)
strong_this->read_from_transport();
});
} else if (fd_tag != 0) {
dbgln("Unexpected byte {:x} in MessagePort transfer data", fd_tag);
@ -200,11 +201,13 @@ void MessagePort::entangle_with(MessagePort& remote_port)
m_remote_port->m_transport = make<IPC::Transport>(move(sockets[1]));
m_transport->set_up_read_hook([strong_this = GC::make_root(this)]() {
strong_this->read_from_transport();
if (strong_this->m_enabled)
strong_this->read_from_transport();
});
m_remote_port->m_transport->set_up_read_hook([remote_port = GC::make_root(m_remote_port)]() {
remote_port->read_from_transport();
if (remote_port->m_enabled)
remote_port->read_from_transport();
});
}
@ -297,6 +300,8 @@ void MessagePort::post_port_message(SerializedTransferRecord serialize_with_tran
void MessagePort::read_from_transport()
{
VERIFY(m_enabled);
auto schedule_shutdown = m_transport->read_as_many_messages_as_possible_without_blocking([this](auto&& raw_message) {
FixedMemoryStream stream { raw_message.bytes.span(), FixedMemoryStream::Mode::ReadOnly };
IPC::Decoder decoder { stream, raw_message.fds };
@ -317,6 +322,8 @@ void MessagePort::read_from_transport()
void MessagePort::post_message_task_steps(SerializedTransferRecord& serialize_with_transfer_result)
{
VERIFY(m_enabled);
// 1. Let finalTargetPort be the MessagePort in whose port message queue the task now finds itself.
// NOTE: This can be different from targetPort, if targetPort itself was transferred and thus all its tasks moved along with it.
auto* final_target_port = this;
@ -368,6 +375,14 @@ void MessagePort::post_message_task_steps(SerializedTransferRecord& serialize_wi
message_event_target->dispatch_event(event);
}
void MessagePort::enable()
{
if (!m_enabled) {
m_enabled = true;
read_from_transport();
}
}
// https://html.spec.whatwg.org/multipage/web-messaging.html#dom-messageport-start
void MessagePort::start()
{
@ -376,7 +391,8 @@ void MessagePort::start()
VERIFY(m_transport);
// TODO: The start() method steps are to enable this's port message queue, if it is not already enabled.
// The start() method steps are to enable this's port message queue, if it is not already enabled.
enable();
}
// https://html.spec.whatwg.org/multipage/web-messaging.html#dom-messageport-close