mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-02 06:09:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Run update_finished_state when setting AnimationEffect's timing

Browse source 
This will need to a necessary style invalidation
This commit is contained in:
Matthew Olsson 2024-02-10 20:54:42 -07:00 • committed by Andrew Kaster
commit 3721a1a81c
Notes: sideshowbarker 2024-07-17 05:02:35 +09:00
3 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Animations/Animation.cpp
View file

@ -509,6 +509,11 @@ void Animation::notify_timeline_time_did_change()
} }
} }
void Animation::effect_timing_changed(Badge<AnimationEffect>)
{
update_finished_state(DidSeek::No, SynchronouslyNotify::Yes);
}
// https://www.w3.org/TR/web-animations-1/#associated-effect-end // https://www.w3.org/TR/web-animations-1/#associated-effect-end
double Animation::associated_effect_end() const double Animation::associated_effect_end() const
{ {

2
Userland/Libraries/LibWeb/Animations/Animation.h
View file

@ -65,6 +65,8 @@ public:
JS::GCPtr<DOM::Document> document_for_timing() const; JS::GCPtr<DOM::Document> document_for_timing() const;
void notify_timeline_time_did_change(); void notify_timeline_time_did_change();
void effect_timing_changed(Badge<AnimationEffect>);
protected: protected:
Animation(JS::Realm&); Animation(JS::Realm&);

3
Userland/Libraries/LibWeb/Animations/AnimationEffect.cpp
View file

@ -151,6 +151,9 @@ WebIDL::ExceptionOr<void> AnimationEffect::update_timing(OptionalEffectTiming ti
if (timing.easing.has_value()) if (timing.easing.has_value())
m_easing_function = timing.easing.value(); m_easing_function = timing.easing.value();
if (auto animation = m_associated_animation)
animation->effect_timing_changed({});
return {}; return {};
} }