From 3794665b0b2e17f0981a875b71626c57e12cf26a Mon Sep 17 00:00:00 2001
From: Sam Atkins <sam@ladybird.org>
Date: Fri, 31 Jan 2025 14:18:46 +0000
Subject: [PATCH] LibWeb/DOM: Add spec steps for WebDriver BiDi to document
 history algo

This is "update document for history step application" but that's too
long for the commit title. :^)

No code changes, just adding more FIXME comments for the new steps.
(And indented step 7's substeps for clarity.)

Corresponds to https://github.com/whatwg/html/pull/10910
---
 Libraries/LibWeb/DOM/Document.cpp | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/Libraries/LibWeb/DOM/Document.cpp b/Libraries/LibWeb/DOM/Document.cpp
index 2717b7552a8..bc498516448 100644
--- a/Libraries/LibWeb/DOM/Document.cpp
+++ b/Libraries/LibWeb/DOM/Document.cpp
@@ -4973,26 +4973,31 @@ void Document::update_for_history_step_application(GC::Ref<HTML::SessionHistoryE
     //    - previousEntryForActivation is given;
     //    - navigationType is non-null; and
     //    - navigationType is "reload" or previousEntryForActivation's document is not document, then:
+    {
+        // FIXME: 1. If navigation's activation is null, then set navigation's activation to a new NavigationActivation object in navigation's relevant realm.
+        // FIXME: 2. Let previousEntryIndex be the result of getting the navigation API entry index of previousEntryForActivation within navigation.
+        // FIXME: 3. If previousEntryIndex is non-negative, then set activation's old entry to navigation's entry list[previousEntryIndex].
 
-    // FIXME: 1. If navigation's activation is null, then set navigation's activation to a new NavigationActivation object in navigation's relevant realm.
-    // FIXME: 2. Let previousEntryIndex be the result of getting the navigation API entry index of previousEntryForActivation within navigation.
-    // FIXME: 3. If previousEntryIndex is non-negative, then set activation's old entry to navigation's entry list[previousEntryIndex].
+        // FIXME: 4. Otherwise, if all the following are true:
+        //    - navigationType is "replace";
+        //    - previousEntryForActivation's document state's origin is same origin with document's origin; and
+        //    - previousEntryForActivation's document's initial about:blank is false,
+        //    then set activation's old entry to a new NavigationHistoryEntry in navigation's relevant realm, whose session history entry is previousEntryForActivation.
 
-    // FIXME: 4. Otherwise, if all the following are true:
-    //    - navigationType is "replace";
-    //    - previousEntryForActivation's document state's origin is same origin with document's origin; and
-    //    - previousEntryForActivation's document's initial about:blank is false,
-    //    then set activation's old entry to a new NavigationHistoryEntry in navigation's relevant realm, whose session history entry is previousEntryForActivation.
-
-    // FIXME: 5. Set activation's new entry to navigation's current entry.
-    // FIXME: 6. Set activation's navigation type to navigationType.
+        // FIXME: 5. Set activation's new entry to navigation's current entry.
+        // FIXME: 6. Set activation's navigation type to navigationType.
+    }
 
     // 8. If documentIsNew is true, then:
     if (document_is_new) {
-        // 1. Try to scroll to the fragment for document.
+        // FIXME: 1. Assert: document's during-loading navigation ID for WebDriver BiDi is not null.
+        // FIXME: 2. Invoke WebDriver BiDi navigation committed with navigable and a new WebDriver BiDi navigation
+        //           status whose id is document's during-loading navigation ID for WebDriver BiDi, status is "committed", and url is document's URL
+
+        // 3. Try to scroll to the fragment for document.
         try_to_scroll_to_the_fragment();
 
-        // 2. At this point scripts may run for the newly-created document document.
+        // 4. At this point scripts may run for the newly-created document document.
         m_ready_to_run_scripts = true;
     }