mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-30 23:12:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Replace templated retarget function with a regular one

Browse source 
The templating is not necessary anywhere and was effectively just a cast
This commit is contained in:
circl 2024-07-21 15:06:05 +02:00 • committed by Andrew Kaster
parent 3adfdd3257
commit 37f93e4be1
Notes: github-actions[bot] 2024-07-21 22:02:25 +00:00
5 changed files with 49 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/DOM/EventDispatcher.cpp
View file

@ -196,7 +196,7 @@ bool EventDispatcher::dispatch(JS::NonnullGCPtr<EventTarget> target, Event& even
JS::GCPtr<EventTarget> activation_target;
// 4. Let relatedTarget be the result of retargeting event’s relatedTarget against target.
JS::GCPtr<EventTarget> related_target = retarget<EventTarget>(event.related_target(), target);
JS::GCPtr<EventTarget> related_target = retarget(event.related_target(), target);
bool clear_targets = false;
// 5. If target is not relatedTarget or target is event’s relatedTarget, then:
@ -206,7 +206,7 @@ bool EventDispatcher::dispatch(JS::NonnullGCPtr<EventTarget> target, Event& even
// 2. For each touchTarget of event’s touch target list, append the result of retargeting touchTarget against target to touchTargets.
for (auto& touch_target : event.touch_target_list()) {
touch_targets.append(retarget<EventTarget>(touch_target, target));
touch_targets.append(retarget(touch_target, target));
}
// 3. Append to an event path with event, target, targetOverride, relatedTarget, touchTargets, and false.
@ -253,14 +253,14 @@ bool EventDispatcher::dispatch(JS::NonnullGCPtr<EventTarget> target, Event& even
slottable = parent;
// 3. Let relatedTarget be the result of retargeting event’s relatedTarget against parent.
related_target = retarget<EventTarget>(event.related_target(), parent);
related_target = retarget(event.related_target(), parent);
// 4. Let touchTargets be a new list.
touch_targets.clear();
// 5. For each touchTarget of event’s touch target list, append the result of retargeting touchTarget against parent to touchTargets.
for (auto& touch_target : event.touch_target_list()) {
touch_targets.append(retarget<EventTarget>(touch_target, parent));
touch_targets.append(retarget(touch_target, parent));
}
// 6. If parent is a Window object, or parent is a node and target’s root is a shadow-including inclusive ancestor of parent, then: