From 3804c4dea1a8e4296327ca570e012264ee2580b3 Mon Sep 17 00:00:00 2001 From: Glenn Skrzypczak Date: Sat, 12 Oct 2024 23:30:49 +0200 Subject: [PATCH] LibWeb: Don't crash when encountering a resolution in a calculation calc() seems to support resolutions by now. The change allows us to pass this WPT test: http://wpt.live/css/css-values/round-mod-rem-invalid.html --- Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp b/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp index 0e6e744debf..187b4f8ebb6 100644 --- a/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp +++ b/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp @@ -7,6 +7,7 @@ * Copyright (c) 2024, Shannon Booth * Copyright (c) 2024, Tommy van der Vorst * Copyright (c) 2024, Matthew Olsson + * Copyright (c) 2024, Glenn Skrzypczak * * SPDX-License-Identifier: BSD-2-Clause */ @@ -8437,7 +8438,8 @@ OwnPtr Parser::parse_a_calculation(Vector const values.append({ NumericCalculationNode::create(dimension->length()) }); else if (dimension->is_percentage()) values.append({ NumericCalculationNode::create(dimension->percentage()) }); - // FIXME: Resolutions, once calc() supports them. + else if (dimension->is_resolution()) + values.append({ NumericCalculationNode::create(dimension->resolution()) }); else if (dimension->is_time()) values.append({ NumericCalculationNode::create(dimension->time()) }); else if (dimension->is_flex()) {