Kernel: Fix integer overflow in framebuffer resolution handling

This made it possible to map the E1000 MMIO range into userspace and
mess with the registers.

Thanks to @grigoritchy for finding this!

Fixes #2015.
This commit is contained in:
Andreas Kling 2020-04-29 09:35:19 +02:00
commit 385dacce05
Notes: sideshowbarker 2024-07-19 07:12:06 +09:00
5 changed files with 23 additions and 23 deletions

View file

@ -40,7 +40,7 @@ MBVGADevice& MBVGADevice::the()
return *s_the;
}
MBVGADevice::MBVGADevice(PhysicalAddress addr, int pitch, int width, int height)
MBVGADevice::MBVGADevice(PhysicalAddress addr, size_t pitch, size_t width, size_t height)
: BlockDevice(29, 0)
, m_framebuffer_address(addr)
, m_framebuffer_pitch(pitch)