mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-06 16:19:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/Fetch: Return a cloned cached response body

Browse source 
Otherwise we will fully read from the cached response and invalidate
it's stream, invalidating it for the next time it is read from. Fixes
a crash when reloading linegoup.lol after two reloads.
This commit is contained in:
Shannon Booth 2024-12-26 14:58:27 +13:00 • committed by Andreas Kling
commit 3913e9f948
Notes: github-actions[bot] 2024-12-26 12:45:46 +00:00
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/Fetch/Fetching/Fetching.cpp
View file

@ -1351,7 +1351,7 @@ WebIDL::ExceptionOr<GC::Ptr<PendingResponse>> http_redirect_fetch(JS::Realm& rea
class CachePartition : public RefCounted<CachePartition> { class CachePartition : public RefCounted<CachePartition> {
public: public:
// https://httpwg.org/specs/rfc9111.html#constructing.responses.from.caches // https://httpwg.org/specs/rfc9111.html#constructing.responses.from.caches
GC::Ptr<Infrastructure::Response> select_response(URL::URL const& url, ReadonlyBytes method, Vector<Infrastructure::Header> const& headers, Vector<GC::Ptr<Infrastructure::Response>>& initial_set_of_stored_responses) const GC::Ptr<Infrastructure::Response> select_response(JS::Realm& realm, URL::URL const& url, ReadonlyBytes method, Vector<Infrastructure::Header> const& headers, Vector<GC::Ptr<Infrastructure::Response>>& initial_set_of_stored_responses) const
{ {
// When presented with a request, a cache MUST NOT reuse a stored response unless: // When presented with a request, a cache MUST NOT reuse a stored response unless:
@ -1383,7 +1383,7 @@ public:
dbgln("\033[32;1mHTTP CACHE HIT!\033[0m {}", url); dbgln("\033[32;1mHTTP CACHE HIT!\033[0m {}", url);
return cached_response.ptr(); return cached_response->clone(realm);
} }
void store_response(JS::Realm& realm, Infrastructure::Request const& http_request, Infrastructure::Response const& response) void store_response(JS::Realm& realm, Infrastructure::Request const& http_request, Infrastructure::Response const& response)
@ -1939,7 +1939,7 @@ WebIDL::ExceptionOr<GC::Ref<PendingResponse>> http_network_or_cache_fetch(JS::Re
// validation, as per the "Constructing Responses from Caches" chapter of HTTP Caching [HTTP-CACHING], // validation, as per the "Constructing Responses from Caches" chapter of HTTP Caching [HTTP-CACHING],
// if any. // if any.
// NOTE: As mandated by HTTP, this still takes the `Vary` header into account. // NOTE: As mandated by HTTP, this still takes the `Vary` header into account.
stored_response = http_cache->select_response(http_request->current_url(), http_request->method(), *http_request->header_list(), initial_set_of_stored_responses); stored_response = http_cache->select_response(realm, http_request->current_url(), http_request->method(), *http_request->header_list(), initial_set_of_stored_responses);
// 2. If storedResponse is non-null, then: // 2. If storedResponse is non-null, then:
if (stored_response) { if (stored_response) {
// 1. If cache mode is "default", storedResponse is a stale-while-revalidate response, // 1. If cache mode is "default", storedResponse is a stale-while-revalidate response,