mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-28 05:07:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Rename internals.signalTextTestIsDone() to signalTestIsDone()

Browse source 
In upcoming change this function will be used for ref-tests as well.
This commit is contained in:
Aliaksandr Kalenik 2025-03-18 17:37:32 +01:00 • committed by Jelle Raaijmakers
commit 394073f611
Notes: github-actions[bot] 2025-03-18 19:11:00 +00:00
20 changed files with 30 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/Internals/Internals.cpp
View file

@ -48,9 +48,9 @@ Page& Internals::internals_page() const
return internals_window().page();
}
void Internals::signal_text_test_is_done(String const& text)
void Internals::signal_test_is_done(String const& text)
{
internals_page().client().page_did_finish_text_test(text);
internals_page().client().page_did_finish_test(text);
}
void Internals::set_test_timeout(double milliseconds)

2
Libraries/LibWeb/Internals/Internals.h
View file

@ -20,7 +20,7 @@ class Internals final : public Bindings::PlatformObject {
public:
virtual ~Internals() override;
void signal_text_test_is_done(String const& text);
void signal_test_is_done(String const& text);
void set_test_timeout(double milliseconds);
void gc();

2
Libraries/LibWeb/Internals/Internals.idl
View file

@ -5,7 +5,7 @@
[Exposed=Nobody]
interface Internals {
undefined signalTextTestIsDone(DOMString text);
undefined signalTestIsDone(DOMString text);
undefined setTestTimeout(double milliseconds);
undefined gc();

2
Libraries/LibWeb/Page/Page.h
View file

@ -385,7 +385,7 @@ public:
virtual void page_did_request_file_picker([[maybe_unused]] HTML::FileFilter const& accepted_file_types, Web::HTML::AllowMultipleFiles) { }
virtual void page_did_request_select_dropdown([[maybe_unused]] Web::CSSPixelPoint content_position, [[maybe_unused]] Web::CSSPixels minimum_width, [[maybe_unused]] Vector<Web::HTML::SelectItem> items) { }
virtual void page_did_finish_text_test([[maybe_unused]] String const& text) { }
virtual void page_did_finish_test([[maybe_unused]] String const& text) { }
virtual void page_did_set_test_timeout([[maybe_unused]] double milliseconds) { }
virtual void page_did_set_browser_zoom([[maybe_unused]] double factor) { }

2
Libraries/LibWebView/ViewImplementation.h
View file

@ -235,7 +235,7 @@ public:
Function<void(Gfx::IntPoint content_position, i32 minimum_width, Vector<Web::HTML::SelectItem> items)> on_request_select_dropdown;
Function<void(Web::KeyEvent const&)> on_finish_handling_key_event;
Function<void(Web::DragEvent const&)> on_finish_handling_drag_event;
Function<void(String const&)> on_text_test_finish;
Function<void(String const&)> on_test_finish;
Function<void(double milliseconds)> on_set_test_timeout;
Function<void(double factor)> on_set_browser_zoom;
Function<void(size_t current_match_index, Optional<size_t> const& total_match_count)> on_find_in_page;

6
Libraries/LibWebView/WebContentClient.cpp
View file

@ -103,11 +103,11 @@ void WebContentClient::did_finish_loading(u64 page_id, URL::URL url)
}
}
void WebContentClient::did_finish_text_test(u64 page_id, String text)
void WebContentClient::did_finish_test(u64 page_id, String text)
{
if (auto view = view_for_page_id(page_id); view.has_value()) {
if (view->on_text_test_finish)
view->on_text_test_finish(text);
if (view->on_test_finish)
view->on_test_finish(text);
}
}

2
Libraries/LibWebView/WebContentClient.h
View file

@ -119,7 +119,7 @@ private:
virtual void did_request_file_picker(u64 page_id, Web::HTML::FileFilter accepted_file_types, Web::HTML::AllowMultipleFiles) override;
virtual void did_request_select_dropdown(u64 page_id, Gfx::IntPoint content_position, i32 minimum_width, Vector<Web::HTML::SelectItem> items) override;
virtual void did_finish_handling_input_event(u64 page_id, Web::EventResult event_result) override;
virtual void did_finish_text_test(u64 page_id, String text) override;
virtual void did_finish_test(u64 page_id, String text) override;
virtual void did_set_test_timeout(u64 page_id, double milliseconds) override;
virtual void did_set_browser_zoom(u64 page_id, double factor) override;
virtual void did_find_in_page(u64 page_id, size_t current_match_index, Optional<size_t> total_match_count) override;