mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 11:49:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Disallow default as a keyframe name

Browse source
This commit is contained in:
Tim Ledbetter 2025-06-14 08:17:15 +01:00 • committed by Tim Flynn
commit 39cef6eeb5
Notes: github-actions[bot] 2025-06-14 21:57:11 +00:00
3 changed files with 71 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/CSS/Parser/RuleParsing.cpp
View file

@ -389,7 +389,7 @@ GC::Ptr<CSSKeyframesRule> Parser::convert_to_keyframes_rule(AtRule const& rule)
return {};
}
if (name_token.is(Token::Type::Ident) && (is_css_wide_keyword(name_token.ident()) || name_token.ident().equals_ignoring_ascii_case("none"sv))) {
if (name_token.is(Token::Type::Ident) && (is_css_wide_keyword(name_token.ident()) || name_token.ident().is_one_of_ignoring_ascii_case("none"sv, "default"sv))) {
dbgln_if(CSS_PARSER_DEBUG, "CSSParser: @keyframes rule name is invalid: {}; discarding.", name_token.ident());
return {};
}

24
Tests/LibWeb/Text/expected/wpt-import/css/css-animations/parsing/keyframes-name-invalid.txt Normal file
View file

@ -0,0 +1,24 @@
Harness status: OK
Found 19 tests
19 Pass
Pass invalid: @keyframes none { }
Pass invalid: @keyframes default { }
Pass invalid: @keyframes initial { }
Pass invalid: @keyframes inherit { }
Pass invalid: @keyframes unset { }
Pass invalid: @keyframes revert { }
Pass invalid: @keyframes revert-layer { }
Pass invalid: @keyframes 12 { }
Pass invalid: @keyframes -12 { }
Pass invalid: @keyframes 12foo { }
Pass invalid: @keyframes foo.bar { }
Pass invalid: @keyframes one two { }
Pass invalid: @keyframes one, two { }
Pass invalid: @keyframes one, initial { }
Pass invalid: @keyframes one, inherit { }
Pass invalid: @keyframes one, unset { }
Pass invalid: @keyframes default, two { }
Pass invalid: @keyframes revert, three { }
Pass invalid: @keyframes revert-layer, four { }

46
Tests/LibWeb/Text/input/wpt-import/css/css-animations/parsing/keyframes-name-invalid.html Normal file
View file

@ -0,0 +1,46 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>CSS Animations: parsing @keyframes name with invalid values</title>
<link rel="author" title="yisibl(一丝)" href="https://github.com/yisibl"/>
<link rel="help" href="https://drafts.csswg.org/css-animations/#typedef-keyframes-name">
<meta name="assert" content="@keyframes name supports the full grammar '<custom-ident> | <string>'.">
<script src="../../../resources/testharness.js"></script>
<script src="../../../resources/testharnessreport.js"></script>
<script src="../../../css/support/parsing-testcommon.js"></script>
</head>
<body>
<div>
<main id="main"></main>
</div>
<script>
test_keyframes_name_invalid('none');
// The CSS-wide keywords are not valid <custom-ident>s. The default keyword is reserved and is also not a valid <custom-ident>.
// Spec: https://drafts.csswg.org/css-values-4/#identifier-value
test_keyframes_name_invalid('default');
test_keyframes_name_invalid('initial');
test_keyframes_name_invalid('inherit');
test_keyframes_name_invalid('unset');
test_keyframes_name_invalid('revert');
test_keyframes_name_invalid('revert-layer');
test_keyframes_name_invalid('12');
test_keyframes_name_invalid('-12');
test_keyframes_name_invalid('12foo');
test_keyframes_name_invalid('foo.bar');
test_keyframes_name_invalid('one two');
test_keyframes_name_invalid('one, two');
test_keyframes_name_invalid('one, initial');
test_keyframes_name_invalid('one, inherit');
test_keyframes_name_invalid('one, unset');
test_keyframes_name_invalid('default, two');
test_keyframes_name_invalid('revert, three');
test_keyframes_name_invalid('revert-layer, four');
// TODO: https://bugs.chromium.org/p/chromium/issues/detail?id=1342609
// test_keyframes_name_invalid('--foo');
</script>
</body>
</html>