mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 20:15:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

IDLGenerators: Add support for custom attribute [ExplicitNull]

Browse source 
This can apply to optional, nullable parameters of platform types. This
will cause the generator to generate the type as
Optional<JS::GCPtr<T>> rather than JS::GCPtr<T>, allowing the
implementation to differentiate between the case where the argument was
not passed, and the case where null or undefined was passed.

Needing to differentiate these two cases is quite niche, hence why it is
an opt-in behavior.
This commit is contained in:
Matthew Olsson 2024-02-18 09:19:13 -07:00 • committed by Tim Flynn
parent 591c8d2b68
commit 39f5e32ee9
Notes: sideshowbarker 2024-07-17 08:59:18 +09:00
1 changed files with 40 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View file

@ -374,6 +374,7 @@ static void generate_to_cpp(SourceGenerator& generator, ParameterType& parameter
{
auto scoped_generator = generator.fork();
auto acceptable_cpp_name = make_input_acceptable_cpp(cpp_name);
auto explicit_null = parameter.extended_attributes.contains("ExplicitNull");
scoped_generator.set("cpp_name", acceptable_cpp_name);
scoped_generator.set("js_name", js_name);
scoped_generator.set("js_suffix", js_suffix);
@ -381,6 +382,18 @@ static void generate_to_cpp(SourceGenerator& generator, ParameterType& parameter
scoped_generator.set("string_type", string_to_fly_string ? "FlyString" : "String");
scoped_generator.set("parameter.type.name", parameter.type->name());
if (explicit_null) {
if (!IDL::is_platform_object(*parameter.type)) {
dbgln("Parameter marked [ExplicitNull] in interface {} must be a platform object", interface.name);
VERIFY_NOT_REACHED();
}
if (!optional || !parameter.type->is_nullable()) {
dbgln("Parameter marked [ExplicitNull] in interface {} must be an optional and nullable type", interface.name);
VERIFY_NOT_REACHED();
}
}
if (optional_default_value.has_value())
scoped_generator.set("parameter.optional_default_value", *optional_default_value);
@ -436,8 +449,19 @@ static void generate_to_cpp(SourceGenerator& generator, ParameterType& parameter
)~~~");
}
} else {
if (explicit_null) {
scoped_generator.append(R"~~~(
Optional<JS::GCPtr<@parameter.type.name@>> @cpp_name@;
if (maybe_@js_name@@js_suffix@.has_value()) {
auto @js_name@@js_suffix@ = maybe_@js_name@@js_suffix@.release_value();
)~~~");
} else {
scoped_generator.append(R"~~~(
JS::GCPtr<@parameter.type.name@> @cpp_name@;
)~~~");
}
scoped_generator.append(R"~~~(
@parameter.type.name@* @cpp_name@ = nullptr;
if (!@js_name@@js_suffix@.is_nullish()) {
if (!@js_name@@js_suffix@.is_object() || !is<@parameter.type.name@>(@js_name@@js_suffix@.as_object()))
return vm.throw_completion<JS::TypeError>(JS::ErrorType::NotAnObjectOfType, "@parameter.type.name@");
@ -445,6 +469,12 @@ static void generate_to_cpp(SourceGenerator& generator, ParameterType& parameter
@cpp_name@ = &static_cast<@parameter.type.name@&>(@js_name@@js_suffix@.as_object());
}
)~~~");
if (explicit_null) {
scoped_generator.append(R"~~~(
}
)~~~");
}
}
} else if (parameter.type->name() == "double" || parameter.type->name() == "float") {
if (!optional) {
@ -1576,9 +1606,17 @@ static void generate_arguments(SourceGenerator& generator, Vector<IDL::Parameter
parameter_names.append(move(parameter_name));
arguments_generator.set("argument.index", ByteString::number(argument_index));
arguments_generator.append(R"~~~(
if (parameter.extended_attributes.contains("ExplicitNull")) {
arguments_generator.set("argument.size", ByteString::number(argument_index + 1));
arguments_generator.append(R"~~~(
auto maybe_arg@argument.index@ = vm.argument_count() >= @argument.size@ ? Optional<JS::Value> { vm.argument(@argument.index@) } : OptionalNone {};
)~~~");
} else {
arguments_generator.append(R"~~~(
auto arg@argument.index@ = vm.argument(@argument.index@);
)~~~");
}
}
bool legacy_null_to_empty_string = parameter.extended_attributes.contains("LegacyNullToEmptyString");