mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 13:19:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Make array_like_size() non-virtual in IndexedPropertyStorage
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macOS, macos-15, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, Linux, blacksmith-16vcpu-ubuntu-2404, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, Linux, blacksmith-16vcpu-ubuntu-2404, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, Linux, blacksmith-16vcpu-ubuntu-2404, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (arm64, macOS, macOS-arm64, macos-15) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, Linux, Linux-x86_64, blacksmith-8vcpu-ubuntu-2404) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source
This commit is contained in:
Aliaksandr Kalenik 2025-06-04 17:52:06 +02:00 • committed by Alexander Kalenik
commit 3b68fd0b8e
Notes: github-actions[bot] 2025-06-05 01:44:37 +00:00
2 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibJS/Runtime/IndexedProperties.h
View file

@ -41,17 +41,20 @@ public:
virtual ValueAndAttributes take_last() = 0;
virtual size_t size() const = 0;
virtual size_t array_like_size() const = 0;
size_t array_like_size() const { return m_array_size; }
virtual bool set_array_like_size(size_t new_size) = 0;
bool is_simple_storage() const { return m_is_simple_storage; }
protected:
explicit IndexedPropertyStorage(IsSimpleStorage is_simple_storage)
: m_is_simple_storage(is_simple_storage == IsSimpleStorage::Yes)
explicit IndexedPropertyStorage(IsSimpleStorage is_simple_storage, size_t array_size = 0)
: m_array_size(array_size)
, m_is_simple_storage(is_simple_storage == IsSimpleStorage::Yes)
{
}
size_t m_array_size { 0 };
private:
bool m_is_simple_storage { false };
};
@ -73,7 +76,6 @@ public:
virtual ValueAndAttributes take_last() override;
virtual size_t size() const override { return m_packed_elements.size(); }
virtual size_t array_like_size() const override { return m_array_size; }
virtual bool set_array_like_size(size_t new_size) override;
Vector<Value> const& elements() const { return m_packed_elements; }
@ -97,7 +99,6 @@ private:
void grow_storage_if_needed();
size_t m_array_size { 0 };
Checked<size_t> m_number_of_empty_elements { 0 };
Vector<Value> m_packed_elements;
};
@ -119,13 +120,11 @@ public:
virtual ValueAndAttributes take_last() override;
virtual size_t size() const override { return m_sparse_elements.size(); }
virtual size_t array_like_size() const override { return m_array_size; }
virtual bool set_array_like_size(size_t new_size) override;
HashMap<u32, ValueAndAttributes> const& sparse_elements() const { return m_sparse_elements; }
private:
size_t m_array_size { 0 };
HashMap<u32, ValueAndAttributes> m_sparse_elements;
};