mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-22 10:19:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use correct scope when removing style sheet inside a shadow tree

Browse source 
Before this change, removing a style element from inside a shadow tree
would cause it to be unregistered with the document-level list of sheets
instead of the shadow-root-level list.

This would eventually lead to a verification failure if someone tried to
update the text contents of that style element, since it was still in
the shadow-root-level list, but now with a null owner element.

Fixes a crash on https://www.swedbank.se/
This commit is contained in:
Andreas Kling 2024-07-23 09:53:32 +02:00 • committed by Andreas Kling
commit 3b7534b362
Notes: github-actions[bot] 2024-07-23 09:13:10 +00:00
6 changed files with 45 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/StyleElementUtils.h
View file

@ -14,7 +14,7 @@ namespace Web::DOM {
class StyleElementUtils {
public:
void update_a_style_block(DOM::Element& style_element);
void update_a_style_block(DOM::Element& style_element, JS::GCPtr<DOM::Node> old_parent_if_removed_from = nullptr);
CSS::CSSStyleSheet* sheet() { return m_associated_css_style_sheet; }
CSS::CSSStyleSheet const* sheet() const { return m_associated_css_style_sheet; }