mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibGC: Rename MarkedVector => RootVector

Browse source 
Let's try to make it a bit more clear that this is a Vector of GC roots.
This commit is contained in:
Andreas Kling 2024-12-26 14:32:52 +01:00 • committed by Andreas Kling
commit 3bfb0534be
Notes: github-actions[bot] 2024-12-26 18:11:36 +00:00
117 changed files with 281 additions and 281 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/AudioTrackList.h
View file

@ -8,7 +8,7 @@
#include <AK/Badge.h>
#include <AK/String.h>
#include <LibGC/MarkedVector.h>
#include <LibGC/RootVector.h>
#include <LibWeb/DOM/EventTarget.h>
#include <LibWeb/HTML/AudioTrack.h>

2
Libraries/LibWeb/HTML/BroadcastChannel.cpp
View file

@ -121,7 +121,7 @@ WebIDL::ExceptionOr<void> BroadcastChannel::post_message(JS::Value message)
auto source_storage_key = Web::StorageAPI::obtain_a_storage_key_for_non_storage_purposes(relevant_settings_object(*this));
// 6. Let destinations be a list of BroadcastChannel objects that match the following criteria:
GC::MarkedVector<GC::Ref<BroadcastChannel>> destinations(vm.heap());
GC::RootVector<GC::Ref<BroadcastChannel>> destinations(vm.heap());
// * The result of running obtain a storage key for non-storage purposes with their relevant settings object equals sourceStorageKey.
auto same_origin_broadcast_channels = s_broadcast_channel_repository.registered_channels_for_key(source_storage_key);

4
Libraries/LibWeb/HTML/CloseWatcherManager.cpp
View file

@ -31,7 +31,7 @@ void CloseWatcherManager::add(GC::Ref<CloseWatcher> close_watcher)
// If manager's groups's size is less than manager's allowed number of groups
if (m_groups.size() < m_allowed_number_of_groups) {
// then append « closeWatcher » to manager's groups.
GC::MarkedVector<GC::Ref<CloseWatcher>> new_group(realm().heap());
GC::RootVector<GC::Ref<CloseWatcher>> new_group(realm().heap());
new_group.append(close_watcher);
m_groups.append(move(new_group));
} else {
@ -68,7 +68,7 @@ bool CloseWatcherManager::process_close_watchers()
auto& group = m_groups.last();
// Ambiguous spec wording. We copy the groups to avoid modifying the original while iterating.
// See https://github.com/whatwg/html/issues/10240
GC::MarkedVector<GC::Ref<CloseWatcher>> group_copy(realm().heap());
GC::RootVector<GC::Ref<CloseWatcher>> group_copy(realm().heap());
group_copy.ensure_capacity(group.size());
for (auto& close_watcher : group) {
group_copy.append(close_watcher);

4
Libraries/LibWeb/HTML/CrossOrigin/AbstractOperations.cpp
View file

@ -237,13 +237,13 @@ JS::ThrowCompletionOr<bool> cross_origin_set(JS::VM& vm, JS::Object& object, JS:
}
// 7.2.3.7 CrossOriginOwnPropertyKeys ( O ), https://html.spec.whatwg.org/multipage/browsers.html#crossoriginownpropertykeys-(-o-)
GC::MarkedVector<JS::Value> cross_origin_own_property_keys(Variant<HTML::Location const*, HTML::Window const*> const& object)
GC::RootVector<JS::Value> cross_origin_own_property_keys(Variant<HTML::Location const*, HTML::Window const*> const& object)
{
auto& event_loop = HTML::main_thread_event_loop();
auto& vm = event_loop.vm();
// 1. Let keys be a new empty List.
auto keys = GC::MarkedVector<JS::Value> { vm.heap() };
auto keys = GC::RootVector<JS::Value> { vm.heap() };
// 2. For each e of CrossOriginProperties(O), append e.[[Property]] to keys.
for (auto& entry : cross_origin_properties(object))

2
Libraries/LibWeb/HTML/CrossOrigin/AbstractOperations.h
View file

@ -21,6 +21,6 @@ bool is_platform_object_same_origin(JS::Object const&);
Optional<JS::PropertyDescriptor> cross_origin_get_own_property_helper(Variant<HTML::Location*, HTML::Window*> const&, JS::PropertyKey const&);
JS::ThrowCompletionOr<JS::Value> cross_origin_get(JS::VM&, JS::Object const&, JS::PropertyKey const&, JS::Value receiver);
JS::ThrowCompletionOr<bool> cross_origin_set(JS::VM&, JS::Object&, JS::PropertyKey const&, JS::Value, JS::Value receiver);
GC::MarkedVector<JS::Value> cross_origin_own_property_keys(Variant<HTML::Location const*, HTML::Window const*> const&);
GC::RootVector<JS::Value> cross_origin_own_property_keys(Variant<HTML::Location const*, HTML::Window const*> const&);
}

6
Libraries/LibWeb/HTML/EventLoop/TaskQueue.cpp
View file

@ -4,7 +4,7 @@
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibGC/MarkedVector.h>
#include <LibGC/RootVector.h>
#include <LibWeb/HTML/EventLoop/EventLoop.h>
#include <LibWeb/HTML/EventLoop/TaskQueue.h>
@ -63,9 +63,9 @@ void TaskQueue::remove_tasks_matching(Function<bool(HTML::Task const&)> filter)
});
}
GC::MarkedVector<GC::Ref<Task>> TaskQueue::take_tasks_matching(Function<bool(HTML::Task const&)> filter)
GC::RootVector<GC::Ref<Task>> TaskQueue::take_tasks_matching(Function<bool(HTML::Task const&)> filter)
{
GC::MarkedVector<GC::Ref<Task>> matching_tasks(heap());
GC::RootVector<GC::Ref<Task>> matching_tasks(heap());
for (size_t i = 0; i < m_tasks.size();) {
auto& task = m_tasks.at(i);

2
Libraries/LibWeb/HTML/EventLoop/TaskQueue.h
View file

@ -37,7 +37,7 @@ public:
}
void remove_tasks_matching(Function<bool(HTML::Task const&)>);
GC::MarkedVector<GC::Ref<Task>> take_tasks_matching(Function<bool(HTML::Task const&)>);
GC::RootVector<GC::Ref<Task>> take_tasks_matching(Function<bool(HTML::Task const&)>);
Task const* last_added_task() const;

4
Libraries/LibWeb/HTML/HTMLAllCollection.cpp
View file

@ -84,9 +84,9 @@ static bool is_all_named_element(DOM::Element const& element)
|| is<HTML::HTMLTextAreaElement>(element);
}
GC::MarkedVector<GC::Ref<DOM::Element>> HTMLAllCollection::collect_matching_elements() const
GC::RootVector<GC::Ref<DOM::Element>> HTMLAllCollection::collect_matching_elements() const
{
GC::MarkedVector<GC::Ref<DOM::Element>> elements(m_root->heap());
GC::RootVector<GC::Ref<DOM::Element>> elements(m_root->heap());
if (m_scope == Scope::Descendants) {
m_root->for_each_in_subtree_of_type<DOM::Element>([&](auto& element) {
if (m_filter(element))

2
Libraries/LibWeb/HTML/HTMLAllCollection.h
View file

@ -32,7 +32,7 @@ public:
Variant<GC::Ref<DOM::HTMLCollection>, GC::Ref<DOM::Element>, Empty> item(Optional<FlyString> const& name_or_index) const;
Variant<GC::Ref<DOM::HTMLCollection>, GC::Ref<DOM::Element>, Empty> named_item(FlyString const& name) const;
GC::MarkedVector<GC::Ref<DOM::Element>> collect_matching_elements() const;
GC::RootVector<GC::Ref<DOM::Element>> collect_matching_elements() const;
virtual Optional<JS::Value> item_value(size_t index) const override;
virtual JS::Value named_item_value(FlyString const& name) const override;

2
Libraries/LibWeb/HTML/HTMLImageElement.cpp
View file

@ -1037,7 +1037,7 @@ static void update_the_source_set(DOM::Element& element)
TODO();
// 2. Let elements be « el ».
GC::MarkedVector<DOM::Element*> elements(element.heap());
GC::RootVector<DOM::Element*> elements(element.heap());
elements.append(&element);
// 3. If el is an img element whose parent node is a picture element,

4
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View file

@ -1863,12 +1863,12 @@ void HTMLMediaElement::time_marches_on(TimeMarchesOnReason reason)
}
// https://html.spec.whatwg.org/multipage/media.html#take-pending-play-promises
GC::MarkedVector<GC::Ref<WebIDL::Promise>> HTMLMediaElement::take_pending_play_promises()
GC::RootVector<GC::Ref<WebIDL::Promise>> HTMLMediaElement::take_pending_play_promises()
{
// 1. Let promises be an empty list of promises.
// 2. Copy the media element's list of pending play promises to promises.
// 3. Clear the media element's list of pending play promises.
GC::MarkedVector<GC::Ref<WebIDL::Promise>> promises(heap());
GC::RootVector<GC::Ref<WebIDL::Promise>> promises(heap());
promises.extend(move(m_pending_play_promises));
// 4. Return promises.

4
Libraries/LibWeb/HTML/HTMLMediaElement.h
View file

@ -11,7 +11,7 @@
#include <AK/Optional.h>
#include <AK/Time.h>
#include <AK/Variant.h>
#include <LibGC/MarkedVector.h>
#include <LibGC/RootVector.h>
#include <LibGfx/Rect.h>
#include <LibWeb/DOM/DocumentLoadEventDelayer.h>
#include <LibWeb/HTML/CORSSettingAttribute.h>
@ -207,7 +207,7 @@ private:
};
void time_marches_on(TimeMarchesOnReason = TimeMarchesOnReason::NormalPlayback);
GC::MarkedVector<GC::Ref<WebIDL::Promise>> take_pending_play_promises();
GC::RootVector<GC::Ref<WebIDL::Promise>> take_pending_play_promises();
void resolve_pending_play_promises(ReadonlySpan<GC::Ref<WebIDL::Promise>> promises);
void reject_pending_play_promises(ReadonlySpan<GC::Ref<WebIDL::Promise>> promises, GC::Ref<WebIDL::DOMException> error);

4
Libraries/LibWeb/HTML/Location.cpp
View file

@ -7,7 +7,7 @@
#include <AK/String.h>
#include <AK/StringBuilder.h>
#include <LibGC/MarkedVector.h>
#include <LibGC/RootVector.h>
#include <LibJS/Runtime/Completion.h>
#include <LibJS/Runtime/PropertyDescriptor.h>
#include <LibJS/Runtime/PropertyKey.h>
@ -596,7 +596,7 @@ JS::ThrowCompletionOr<bool> Location::internal_delete(JS::PropertyKey const& pro
}
// 7.10.5.10 [[OwnPropertyKeys]] ( ), https://html.spec.whatwg.org/multipage/history.html#location-ownpropertykeys
JS::ThrowCompletionOr<GC::MarkedVector<JS::Value>> Location::internal_own_property_keys() const
JS::ThrowCompletionOr<GC::RootVector<JS::Value>> Location::internal_own_property_keys() const
{
// 1. If IsPlatformObjectSameOrigin(this) is true, then return OrdinaryOwnPropertyKeys(this).
if (HTML::is_platform_object_same_origin(*this))

2
Libraries/LibWeb/HTML/Location.h
View file

@ -63,7 +63,7 @@ public:
virtual JS::ThrowCompletionOr<JS::Value> internal_get(JS::PropertyKey const&, JS::Value receiver, JS::CacheablePropertyMetadata*, PropertyLookupPhase) const override;
virtual JS::ThrowCompletionOr<bool> internal_set(JS::PropertyKey const&, JS::Value value, JS::Value receiver, JS::CacheablePropertyMetadata*) override;
virtual JS::ThrowCompletionOr<bool> internal_delete(JS::PropertyKey const&) override;
virtual JS::ThrowCompletionOr<GC::MarkedVector<JS::Value>> internal_own_property_keys() const override;
virtual JS::ThrowCompletionOr<GC::RootVector<JS::Value>> internal_own_property_keys() const override;
HTML::CrossOriginPropertyDescriptorMap const& cross_origin_property_descriptor_map() const { return m_cross_origin_property_descriptor_map; }
HTML::CrossOriginPropertyDescriptorMap& cross_origin_property_descriptor_map() { return m_cross_origin_property_descriptor_map; }

2
Libraries/LibWeb/HTML/MessageEvent.cpp
View file

@ -66,7 +66,7 @@ Variant<GC::Root<WindowProxy>, GC::Root<MessagePort>, Empty> MessageEvent::sourc
GC::Ref<JS::Object> MessageEvent::ports() const
{
if (!m_ports_array) {
GC::MarkedVector<JS::Value> port_vector(heap());
GC::RootVector<JS::Value> port_vector(heap());
for (auto const& port : m_ports)
port_vector.append(port);

2
Libraries/LibWeb/HTML/Navigation.cpp
View file

@ -1131,7 +1131,7 @@ bool Navigation::inner_navigate_event_firing_algorithm(
// 33. If endResultIsSameDocument is true:
if (end_result_is_same_document) {
// 1. Let promisesList be an empty list.
GC::MarkedVector<GC::Ref<WebIDL::Promise>> promises_list(realm.heap());
GC::RootVector<GC::Ref<WebIDL::Promise>> promises_list(realm.heap());
// 2. For each handler of event's navigation handler list:
for (auto const& handler : event->navigation_handler_list()) {

2
Libraries/LibWeb/HTML/StructuredSerialize.cpp
View file

@ -1040,7 +1040,7 @@ public:
private:
JS::VM& m_vm;
ReadonlySpan<u32> m_serialized;
GC::MarkedVector<JS::Value> m_memory; // Index -> JS value
GC::RootVector<JS::Value> m_memory; // Index -> JS value
size_t m_position { 0 };
static GC::Ref<Bindings::PlatformObject> create_serialized_type(StringView interface_name, JS::Realm& realm)

2
Libraries/LibWeb/HTML/StructuredSerializeTypes.h
View file

@ -10,7 +10,7 @@
namespace Web::HTML {
using DeserializationMemory = GC::MarkedVector<JS::Value>;
using DeserializationMemory = GC::RootVector<JS::Value>;
using SerializationRecord = Vector<u32>;
using SerializationMemory = HashMap<GC::Root<JS::Value>, u32>;

2
Libraries/LibWeb/HTML/TextTrackCue.h
View file

@ -6,7 +6,7 @@
#pragma once
#include <LibGC/MarkedVector.h>
#include <LibGC/RootVector.h>
#include <LibWeb/DOM/EventTarget.h>
#include <LibWeb/HTML/TextTrack.h>

2
Libraries/LibWeb/HTML/TextTrackCueList.h
View file

@ -6,7 +6,7 @@
#pragma once
#include <LibGC/MarkedVector.h>
#include <LibGC/RootVector.h>
#include <LibWeb/DOM/EventTarget.h>
#include <LibWeb/HTML/TextTrackCue.h>

2
Libraries/LibWeb/HTML/TextTrackList.h
View file

@ -6,7 +6,7 @@
#pragma once
#include <LibGC/MarkedVector.h>
#include <LibGC/RootVector.h>
#include <LibWeb/DOM/EventTarget.h>
#include <LibWeb/HTML/TextTrack.h>

2
Libraries/LibWeb/HTML/VideoTrackList.h
View file

@ -8,7 +8,7 @@
#include <AK/Badge.h>
#include <AK/String.h>
#include <LibGC/MarkedVector.h>
#include <LibGC/RootVector.h>
#include <LibWeb/DOM/EventTarget.h>
#include <LibWeb/HTML/VideoTrack.h>

4
Libraries/LibWeb/HTML/Window.cpp
View file

@ -526,7 +526,7 @@ void Window::consume_history_action_user_activation()
auto navigables = top->active_document()->inclusive_descendant_navigables();
// 4. Let windows be the list of Window objects constructed by taking the active window of each item in navigables.
GC::MarkedVector<GC::Ptr<Window>> windows(heap());
GC::RootVector<GC::Ptr<Window>> windows(heap());
for (auto& n : navigables)
windows.append(n->active_window());
@ -551,7 +551,7 @@ void Window::consume_user_activation()
auto navigables = top->active_document()->inclusive_descendant_navigables();
// 4. Let windows be the list of Window objects constructed by taking the active window of each item in navigables.
GC::MarkedVector<GC::Ptr<Window>> windows(heap());
GC::RootVector<GC::Ptr<Window>> windows(heap());
for (auto& n : navigables)
windows.append(n->active_window());

8
Libraries/LibWeb/HTML/WindowOrWorkerGlobalScope.cpp
View file

@ -218,13 +218,13 @@ GC::Ref<WebIDL::Promise> WindowOrWorkerGlobalScopeMixin::fetch(Fetch::RequestInf
}
// https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#dom-settimeout
i32 WindowOrWorkerGlobalScopeMixin::set_timeout(TimerHandler handler, i32 timeout, GC::MarkedVector<JS::Value> arguments)
i32 WindowOrWorkerGlobalScopeMixin::set_timeout(TimerHandler handler, i32 timeout, GC::RootVector<JS::Value> arguments)
{
return run_timer_initialization_steps(move(handler), timeout, move(arguments), Repeat::No);
}
// https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#dom-setinterval
i32 WindowOrWorkerGlobalScopeMixin::set_interval(TimerHandler handler, i32 timeout, GC::MarkedVector<JS::Value> arguments)
i32 WindowOrWorkerGlobalScopeMixin::set_interval(TimerHandler handler, i32 timeout, GC::RootVector<JS::Value> arguments)
{
return run_timer_initialization_steps(move(handler), timeout, move(arguments), Repeat::Yes);
}
@ -254,7 +254,7 @@ void WindowOrWorkerGlobalScopeMixin::clear_map_of_active_timers()
// https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#timer-initialisation-steps
// With no active script fix from https://github.com/whatwg/html/pull/9712
i32 WindowOrWorkerGlobalScopeMixin::run_timer_initialization_steps(TimerHandler handler, i32 timeout, GC::MarkedVector<JS::Value> arguments, Repeat repeat, Optional<i32> previous_id)
i32 WindowOrWorkerGlobalScopeMixin::run_timer_initialization_steps(TimerHandler handler, i32 timeout, GC::RootVector<JS::Value> arguments, Repeat repeat, Optional<i32> previous_id)
{
// 1. Let thisArg be global if that is a WorkerGlobalScope object; otherwise let thisArg be the WindowProxy that corresponds to global.
@ -697,7 +697,7 @@ GC::Ref<JS::Object> WindowOrWorkerGlobalScopeMixin::supported_entry_types() cons
auto& realm = this_impl().realm();
if (!m_supported_entry_types_array) {
GC::MarkedVector<JS::Value> supported_entry_types(vm.heap());
GC::RootVector<JS::Value> supported_entry_types(vm.heap());
#define __ENUMERATE_SUPPORTED_PERFORMANCE_ENTRY_TYPES(entry_type, cpp_class) \
supported_entry_types.append(JS::PrimitiveString::create(vm, entry_type));

6
Libraries/LibWeb/HTML/WindowOrWorkerGlobalScope.h
View file

@ -40,8 +40,8 @@ public:
GC::Ref<WebIDL::Promise> create_image_bitmap(ImageBitmapSource image, WebIDL::Long sx, WebIDL::Long sy, WebIDL::Long sw, WebIDL::Long sh, Optional<ImageBitmapOptions> options = {}) const;
GC::Ref<WebIDL::Promise> fetch(Fetch::RequestInfo const&, Fetch::RequestInit const&) const;
i32 set_timeout(TimerHandler, i32 timeout, GC::MarkedVector<JS::Value> arguments);
i32 set_interval(TimerHandler, i32 timeout, GC::MarkedVector<JS::Value> arguments);
i32 set_timeout(TimerHandler, i32 timeout, GC::RootVector<JS::Value> arguments);
i32 set_interval(TimerHandler, i32 timeout, GC::RootVector<JS::Value> arguments);
void clear_timeout(i32);
void clear_interval(i32);
void clear_map_of_active_timers();
@ -86,7 +86,7 @@ private:
Yes,
No,
};
i32 run_timer_initialization_steps(TimerHandler handler, i32 timeout, GC::MarkedVector<JS::Value> arguments, Repeat repeat, Optional<i32> previous_id = {});
i32 run_timer_initialization_steps(TimerHandler handler, i32 timeout, GC::RootVector<JS::Value> arguments, Repeat repeat, Optional<i32> previous_id = {});
void run_steps_after_a_timeout_impl(i32 timeout, Function<void()> completion_step, Optional<i32> timer_key = {});
GC::Ref<WebIDL::Promise> create_image_bitmap_impl(ImageBitmapSource& image, Optional<WebIDL::Long> sx, Optional<WebIDL::Long> sy, Optional<WebIDL::Long> sw, Optional<WebIDL::Long> sh, Optional<ImageBitmapOptions>& options) const;

6
Libraries/LibWeb/HTML/WindowProxy.cpp
View file

@ -5,7 +5,7 @@
*/
#include <AK/Optional.h>
#include <LibGC/MarkedVector.h>
#include <LibGC/RootVector.h>
#include <LibJS/Runtime/Completion.h>
#include <LibJS/Runtime/GlobalObject.h>
#include <LibJS/Runtime/PropertyDescriptor.h>
@ -228,7 +228,7 @@ JS::ThrowCompletionOr<bool> WindowProxy::internal_delete(JS::PropertyKey const&
}
// 7.4.10 [[OwnPropertyKeys]] ( ), https://html.spec.whatwg.org/multipage/window-object.html#windowproxy-ownpropertykeys
JS::ThrowCompletionOr<GC::MarkedVector<JS::Value>> WindowProxy::internal_own_property_keys() const
JS::ThrowCompletionOr<GC::RootVector<JS::Value>> WindowProxy::internal_own_property_keys() const
{
auto& event_loop = main_thread_event_loop();
auto& vm = event_loop.vm();
@ -236,7 +236,7 @@ JS::ThrowCompletionOr<GC::MarkedVector<JS::Value>> WindowProxy::internal_own_pro
// 1. Let W be the value of the [[Window]] internal slot of this.
// 2. Let keys be a new empty List.
auto keys = GC::MarkedVector<JS::Value> { vm.heap() };
auto keys = GC::RootVector<JS::Value> { vm.heap() };
// 3. Let maxProperties be W's associated Document's document-tree child navigables's size.
auto max_properties = m_window->associated_document().document_tree_child_navigables().size();

2
Libraries/LibWeb/HTML/WindowProxy.h
View file

@ -30,7 +30,7 @@ public:
virtual JS::ThrowCompletionOr<JS::Value> internal_get(JS::PropertyKey const&, JS::Value receiver, JS::CacheablePropertyMetadata*, PropertyLookupPhase) const override;
virtual JS::ThrowCompletionOr<bool> internal_set(JS::PropertyKey const&, JS::Value value, JS::Value receiver, JS::CacheablePropertyMetadata*) override;
virtual JS::ThrowCompletionOr<bool> internal_delete(JS::PropertyKey const&) override;
virtual JS::ThrowCompletionOr<GC::MarkedVector<JS::Value>> internal_own_property_keys() const override;
virtual JS::ThrowCompletionOr<GC::RootVector<JS::Value>> internal_own_property_keys() const override;
GC::Ptr<Window> window() const { return m_window; }
void set_window(GC::Ref<Window>);

4
Libraries/LibWeb/HTML/WorkerDebugConsoleClient.cpp
View file

@ -5,7 +5,7 @@
*/
#include <AK/StringBuilder.h>
#include <LibGC/MarkedVector.h>
#include <LibGC/RootVector.h>
#include <LibJS/Runtime/Completion.h>
#include <LibJS/Runtime/Realm.h>
#include <LibJS/Runtime/VM.h>
@ -60,7 +60,7 @@ JS::ThrowCompletionOr<JS::Value> WorkerDebugConsoleClient::printer(JS::Console::
return JS::js_undefined();
}
auto output = TRY(generically_format_values(arguments.get<GC::MarkedVector<JS::Value>>()));
auto output = TRY(generically_format_values(arguments.get<GC::RootVector<JS::Value>>()));
m_console->output_debug_message(log_level, output);
return JS::js_undefined();
}