mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-08 18:46:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Don't store WindowOrWorkerGlobalScopeMixin in Performance

Browse source 
It wasn't used anyways, instead preferring to do dynamic_casts in every
method. Let's keep doing that, but move it into a helper function.
This commit is contained in:
Matthew Olsson 2024-04-05 18:04:01 -07:00 • committed by Andreas Kling
commit 3c3ead5ff4
Notes: sideshowbarker 2024-07-16 17:12:03 +09:00
5 changed files with 35 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HighResolutionTime/Performance.h
View file

@ -37,7 +37,10 @@ public:
WebIDL::ExceptionOr<Vector<JS::Handle<PerformanceTimeline::PerformanceEntry>>> get_entries_by_name(String const& name, Optional<String> type) const;
private:
explicit Performance(HTML::WindowOrWorkerGlobalScopeMixin&);
explicit Performance(JS::Realm&);
HTML::WindowOrWorkerGlobalScopeMixin& window_or_worker();
HTML::WindowOrWorkerGlobalScopeMixin const& window_or_worker() const;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
@ -45,7 +48,6 @@ private:
WebIDL::ExceptionOr<HighResolutionTime::DOMHighResTimeStamp> convert_name_to_timestamp(JS::Realm& realm, String const& name);
WebIDL::ExceptionOr<HighResolutionTime::DOMHighResTimeStamp> convert_mark_to_timestamp(JS::Realm& realm, Variant<String, HighResolutionTime::DOMHighResTimeStamp> mark);
JS::NonnullGCPtr<HTML::WindowOrWorkerGlobalScopeMixin> m_window_or_worker;
JS::GCPtr<NavigationTiming::PerformanceTiming> m_timing;
Core::ElapsedTimer m_timer;