mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-19 16:59:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: No longer return undefined on null table entry in Wasm API

Browse source 
Return `null` instead, as per the specification.
This commit is contained in:
Diego Frias 2024-07-30 10:24:25 -07:00 • committed by Ali Mohammad Pur
commit 3c5e3eef10
Notes: github-actions[bot] 2024-07-30 21:44:36 +00:00
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/WebAssembly/WebAssembly.cpp
View file

@ -450,7 +450,10 @@ JS::Value to_js_value(JS::VM& vm, Wasm::Value& wasm_value)
case Wasm::ValueType::F32:
return JS::Value(static_cast<double>(wasm_value.to<float>().value()));
case Wasm::ValueType::FunctionReference: {
auto address = wasm_value.to<Wasm::Reference::Func>().value().address;
auto ref_ = *wasm_value.to<Wasm::Reference>();
if (ref_.ref().has<Wasm::Reference::Null>())
return JS::js_null();
auto address = ref_.ref().get<Wasm::Reference::Func>().address;
auto& cache = get_cache(realm);
auto* function = cache.abstract_machine().store().get(address);
auto name = function->visit(