mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-02 06:09:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Add a stubbed slot for DynamicsCompressorNode.reduction

Browse source 
For now, this slot is always 0 - (the default value per spec). But
once we start actually processing audio streams this internal slot
should be changed correspondingly.
This commit is contained in:
Shannon Booth 2024-05-11 20:39:46 +12:00 • committed by Andreas Kling
commit 3ccbc83168
Notes: sideshowbarker 2024-07-16 17:12:03 +09:00
4 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/WebAudio/DynamicsCompressorNode.txt
View file

@ -7,3 +7,4 @@ Object
[object AudioParam] current: 12, default: 12, min: 1, max: 20, rate: k-rate [object AudioParam] current: 12, default: 12, min: 1, max: 20, rate: k-rate
[object AudioParam] current: 0.003000000026077032, default: 0.003000000026077032, min: 0, max: 1, rate: k-rate [object AudioParam] current: 0.003000000026077032, default: 0.003000000026077032, min: 0, max: 1, rate: k-rate
[object AudioParam] current: 0.25, default: 0.25, min: 0, max: 1, rate: k-rate [object AudioParam] current: 0.25, default: 0.25, min: 0, max: 1, rate: k-rate
reduction: 0

3
Tests/LibWeb/Text/input/WebAudio/DynamicsCompressorNode.html
View file

@ -23,5 +23,8 @@
dumpAudioParam(compressor.ratio); dumpAudioParam(compressor.ratio);
dumpAudioParam(compressor.attack); dumpAudioParam(compressor.attack);
dumpAudioParam(compressor.release); dumpAudioParam(compressor.release);
// Default reduction
println(`reduction: ${compressor.reduction}`);
}); });
</script> </script>

4
Userland/Libraries/LibWeb/WebAudio/DynamicsCompressorNode.h
View file

@ -35,6 +35,7 @@ public:
JS::NonnullGCPtr<AudioParam const> ratio() const { return m_ratio; } JS::NonnullGCPtr<AudioParam const> ratio() const { return m_ratio; }
JS::NonnullGCPtr<AudioParam const> attack() const { return m_attack; } JS::NonnullGCPtr<AudioParam const> attack() const { return m_attack; }
JS::NonnullGCPtr<AudioParam const> release() const { return m_release; } JS::NonnullGCPtr<AudioParam const> release() const { return m_release; }
float reduction() const { return m_reduction; }
protected: protected:
DynamicsCompressorNode(JS::Realm&, JS::NonnullGCPtr<BaseAudioContext>, DynamicsCompressorOptions const& = {}); DynamicsCompressorNode(JS::Realm&, JS::NonnullGCPtr<BaseAudioContext>, DynamicsCompressorOptions const& = {});
@ -57,6 +58,9 @@ private:
// https://webaudio.github.io/web-audio-api/#dom-dynamicscompressornode-release // https://webaudio.github.io/web-audio-api/#dom-dynamicscompressornode-release
JS::NonnullGCPtr<AudioParam> m_release; JS::NonnullGCPtr<AudioParam> m_release;
// https://webaudio.github.io/web-audio-api/#dom-dynamicscompressornode-internal-reduction-slot
float m_reduction { 0 }; // [[internal reduction]]
}; };
} }

2
Userland/Libraries/LibWeb/WebAudio/DynamicsCompressorNode.idl
View file

@ -19,7 +19,7 @@ interface DynamicsCompressorNode : AudioNode {
readonly attribute AudioParam threshold; readonly attribute AudioParam threshold;
readonly attribute AudioParam knee; readonly attribute AudioParam knee;
readonly attribute AudioParam ratio; readonly attribute AudioParam ratio;
// FIXME: readonly attribute float reduction; readonly attribute float reduction;
readonly attribute AudioParam attack; readonly attribute AudioParam attack;
readonly attribute AudioParam release; readonly attribute AudioParam release;
}; };