mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-18 16:21:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibJS: Make Value() default-construct the undefined value

Browse source 
The special empty value (that we use for array holes, Optional<Value>
when empty and a few other other placeholder/sentinel tasks) still
exists, but you now create one via JS::js_special_empty_value() and
check for it with Value::is_special_empty_value().

The main idea here is to make it very unlikely to accidentally create an
unexpected special empty value.
This commit is contained in:
Andreas Kling 2025-04-04 23:16:34 +02:00 • committed by Andreas Kling
parent 0d91363742
commit 3cf50539ec
Notes: github-actions[bot] 2025-04-05 09:21:31 +00:00
43 changed files with 165 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Bytecode/Generator.cpp
View file

@ -1304,7 +1304,7 @@ ScopedOperand Generator::add_constant(Value value)
m_null_constant = append_new_constant();
return m_null_constant.value();
}
if (value.is_empty()) {
if (value.is_special_empty_value()) {
if (!m_empty_constant.has_value())
m_empty_constant = append_new_constant();
return m_empty_constant.value();