mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-12 02:59:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Make Value() default-construct the undefined value

Browse source 
The special empty value (that we use for array holes, Optional<Value>
when empty and a few other other placeholder/sentinel tasks) still
exists, but you now create one via JS::js_special_empty_value() and
check for it with Value::is_special_empty_value().

The main idea here is to make it very unlikely to accidentally create an
unexpected special empty value.
This commit is contained in:
Andreas Kling 2025-04-04 23:16:34 +02:00 • committed by Andreas Kling
commit 3cf50539ec
Notes: github-actions[bot] 2025-04-05 09:21:31 +00:00
43 changed files with 165 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibJS/Runtime/Reference.h
View file

@ -30,7 +30,7 @@ public:
{
}
Reference(Value base, PropertyKey name, Value this_value, bool strict = false)
Reference(Value base, PropertyKey name, Optional<Value> this_value, bool strict = false)
: m_base_type(BaseType::Value)
, m_base_value(base)
, m_name(move(name))
@ -90,14 +90,14 @@ public:
{
VERIFY(is_property_reference());
if (is_super_reference())
return m_this_value;
return m_this_value.value();
return m_base_value;
}
// 6.2.4.3 IsSuperReference ( V ), https://tc39.es/ecma262/#sec-issuperreference
bool is_super_reference() const
{
return !m_this_value.is_empty();
return m_this_value.has_value();
}
// 6.2.4.4 IsPrivateReference ( V ), https://tc39.es/ecma262/#sec-isprivatereference
@ -131,7 +131,7 @@ private:
mutable Environment* m_base_environment;
};
Variant<PropertyKey, PrivateName> m_name;
Value m_this_value;
Optional<Value> m_this_value;
bool m_strict { false };
Optional<EnvironmentCoordinate> m_environment_coordinate;