mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 11:36:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Ignore boxes without layout node in intersection observer steps

Browse source 
Check if box has associated layout node is not mentioned in the spec,
but it is required to match behavior of other browsers that do not
invoke intersection observer steps for boxes without layout node.
This commit is contained in:
Aliaksandr Kalenik 2025-04-13 21:36:00 +02:00 • committed by Alexander Kalenik
parent ea8a6b43f7
commit 3e1d718b7f
Notes: github-actions[bot] 2025-04-14 15:10:55 +00:00
3 changed files with 28 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/DOM/Document.cpp
View file

@ -4663,8 +4663,8 @@ void Document::run_the_update_intersection_observations_steps(HighResolutionTime
auto intersection_root_document = intersection_root.visit([](auto& node) -> GC::Ref<Document> {
return node->document();
});
if (!(observer->root().has<Empty>() && &target->document() == intersection_root_document.ptr())
|| !(intersection_root.has<GC::Root<DOM::Element>>() && !target->is_descendant_of(*intersection_root.get<GC::Root<DOM::Element>>()))) {
// NOTE: Check if target has a layout node is not in the spec but required to match other browsers.
if (target->layout_node() && (!(observer->root().has<Empty>() && &target->document() == intersection_root_document.ptr()) || !(intersection_root.has<GC::Root<DOM::Element>>() && !target->is_descendant_of(*intersection_root.get<GC::Root<DOM::Element>>())))) {
// 4. Set targetRect to the DOMRectReadOnly obtained by getting the bounding box for target.
target_rect = target->get_bounding_client_rect();

2
Tests/LibWeb/Text/expected/IntersectionObserver/box-without-layout-node-should-not-intersect.txt Normal file
View file

@ -0,0 +1,2 @@
flip #container to visible
#nested is visible

24
Tests/LibWeb/Text/input/IntersectionObserver/box-without-layout-node-should-not-intersect.html Normal file
View file

@ -0,0 +1,24 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<div id="container" style="height:200px; display:none">
<div id="nested"></div>
</div>
<script>
asyncTest(done => {
let observer = new IntersectionObserver(entries => {
entries.forEach(entry => {
if (entry.isIntersecting) {
println('#nested is visible');
done();
}
});
});
observer.observe(document.getElementById('nested'));
requestAnimationFrame(() => {
requestAnimationFrame(() => {
println('flip #container to visible');
document.getElementById('container').style.display = 'block';
});
});
});
</script>