mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-09 09:39:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't claim that inline layout nodes can contain abspos elements
Some checks are pending
CI / Linux, x86_64, Sanitizer_CI, Clang (push) Waiting to run
Details
CI / macOS, arm64, Sanitizer_CI, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers_CI, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer_CI, GNU (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
We assume elsewhere that any abspos element's containing block must be
some kind of Layout::Box, so let's enforce that when deciding if a box
can be such a container.

This fixes a bad downcast on https://serpapi.com/
This commit is contained in:
Andreas Kling 2025-05-16 15:57:28 +02:00 • committed by Andreas Kling
commit 3e1ee37c6a
Notes: github-actions[bot] 2025-06-07 22:47:52 +00:00
3 changed files with 31 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/Layout/Node.cpp
View file

@ -76,6 +76,9 @@ bool Node::is_out_of_flow(FormattingContext const& formatting_context) const
bool Node::can_contain_boxes_with_position_absolute() const bool Node::can_contain_boxes_with_position_absolute() const
{ {
if (!is<Box>(*this))
return false;
if (computed_values().position() != CSS::Positioning::Static) if (computed_values().position() != CSS::Positioning::Static)
return true; return true;

16
Tests/LibWeb/Layout/expected/abspos-static-position-containing-block-inline-situation.txt Normal file
View file

@ -0,0 +1,16 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x18 [BFC] children: inline
InlineNode <body>
frag 0 from BlockContainer start: 0, length: 0, rect: [8,13 0x0] baseline: 0
frag 1 from TextNode start: 0, length: 5, rect: [8,0 36.84375x18] baseline: 13.796875
"hello"
BlockContainer <main> at (8,13) content-size 0x0 inline-block [BFC] children: not-inline
BlockContainer <div> at (8,0) content-size 36.84375x18 positioned [BFC] children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x18]
PaintableWithLines (InlineNode<BODY>)
PaintableWithLines (BlockContainer<MAIN>) [8,13 0x0]
PaintableWithLines (BlockContainer<DIV>) [8,0 36.84375x18]
TextPaintable (TextNode<#text>)

12
Tests/LibWeb/Layout/input/abspos-static-position-containing-block-inline-situation.html Normal file
View file

@ -0,0 +1,12 @@
<!doctype html><style>
body {
display: inline;
position: relative;
}
main {
display: inline-block;
}
div {
position: absolute;
}
</style><body><main><div>hello