mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-31 13:19:05 +00:00
Ladybird: Abstract spawning helper processes into separate methods
This will let us use the same path discovery methods for WebContent, SQLServer, and any other helper processes we need to launch.
This commit is contained in:
parent
792258afe8
commit
3e6d790cf0
Notes:
sideshowbarker
2024-07-17 07:09:53 +09:00
Author: https://github.com/ADKaster
Commit: 3e6d790cf0
Pull-request: https://github.com/SerenityOS/serenity/pull/17272
Issue: https://github.com/SerenityOS/serenity/issues/17062
Reviewed-by: https://github.com/trflynn89 ✅
4 changed files with 56 additions and 6 deletions
|
@ -9,6 +9,7 @@
|
|||
|
||||
#include "WebContentView.h"
|
||||
#include "ConsoleWidget.h"
|
||||
#include "HelperProcess.h"
|
||||
#include "InspectorWidget.h"
|
||||
#include "Utilities.h"
|
||||
#include <AK/Assertions.h>
|
||||
|
@ -586,12 +587,7 @@ void WebContentView::create_client()
|
|||
arguments.append(m_webdriver_content_ipc_path);
|
||||
}
|
||||
|
||||
auto result = Core::System::exec("./WebContent/WebContent"sv, arguments, Core::System::SearchInPath::Yes);
|
||||
if (result.is_error()) {
|
||||
auto web_content_path = ak_deprecated_string_from_qstring(QCoreApplication::applicationDirPath() + "/WebContent");
|
||||
result = Core::System::exec(web_content_path, arguments, Core::System::SearchInPath::Yes);
|
||||
}
|
||||
|
||||
auto result = spawn_helper_process("WebContent"sv, arguments, Core::System::SearchInPath::Yes);
|
||||
if (result.is_error())
|
||||
warnln("Could not launch WebContent: {}", result.error());
|
||||
VERIFY_NOT_REACHED();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue