LibCore: CHttpJob::start() should fail asynchronously

Clients are expected to have a chance to set up an on_finish callback
before we finish or fail.
This commit is contained in:
Andreas Kling 2019-10-08 19:32:34 +02:00
parent 31ac19543a
commit 3fdc595e0c
Notes: sideshowbarker 2024-07-19 11:45:14 +09:00

View file

@ -124,8 +124,11 @@ void CHttpJob::start()
on_socket_connected();
};
bool success = m_socket->connect(m_request.url().host(), m_request.url().port());
if (!success)
return did_fail(CNetworkJob::Error::ConnectionFailed);
if (!success) {
deferred_invoke([this](auto&) {
return did_fail(CNetworkJob::Error::ConnectionFailed);
});
}
}
void CHttpJob::shutdown()