mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 11:49:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Insert title as first child on setting title of svg document

Browse source 
Before, the new title element got appended instead of prepended, as
nullptr was passed as the "child" argument to the insert_before()
function.

This change makes two WPT tests pass in:
http://wpt.live/html/dom/documents/dom-tree-accessors/document.title-09.html
This commit is contained in:
ronak69 2024-10-13 17:35:35 +00:00 • committed by Andreas Kling
commit 3ff6137121
Notes: github-actions[bot] 2024-10-14 05:14:48 +00:00
3 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -923,7 +923,7 @@ WebIDL::ExceptionOr<void> Document::set_title(String const& title)
element = TRY(DOM::create_element(*this, HTML::TagNames::title, Namespace::SVG));
// 2. Insert element as the first child of the document element.
document_element->insert_before(*element, nullptr);
document_element->insert_before(*element, document_element->first_child());
}
// 3. String replace all with the given value within element.