mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Implement overload resolution for sequence types

Browse source 
Fixes: #2508
This commit is contained in:
Shannon Booth 2024-11-23 08:01:49 +13:00 • committed by Tim Ledbetter
commit 3fffd1129c
Notes: github-actions[bot] 2024-11-23 02:39:19 +00:00
4 changed files with 65 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Libraries/LibWeb/WebIDL/OverloadResolution.cpp
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org> * Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2024, Shannon Booth <shannon@serenityos.org>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -77,7 +78,7 @@ JS::ThrowCompletionOr<ResolvedOverload> resolve_overload(JS::VM& vm, IDL::Effect
auto distinguishing_argument_index = -1; auto distinguishing_argument_index = -1;
// 7. Initialize method to undefined. // 7. Initialize method to undefined.
Optional<JS::FunctionObject&> method; GC::Ptr<JS::FunctionObject> method;
// 8. If there is more than one entry in S, then set d to be the distinguishing argument index for the entries of S. // 8. If there is more than one entry in S, then set d to be the distinguishing argument index for the entries of S.
if (overloads.size() > 1) if (overloads.size() > 1)
@ -253,7 +254,7 @@ JS::ThrowCompletionOr<ResolvedOverload> resolve_overload(JS::VM& vm, IDL::Effect
overloads.remove_all_other_entries(); overloads.remove_all_other_entries();
} }
// FIXME: 9. Otherwise: if Type(V) is Object and there is an entry in S that has one of the following types at position i of its type list, // 9. Otherwise: if Type(V) is Object and there is an entry in S that has one of the following types at position i of its type list,
// - a sequence type // - a sequence type
// - a frozen array type // - a frozen array type
// - a nullable version of any of the above types // - a nullable version of any of the above types
@ -264,7 +265,28 @@ JS::ThrowCompletionOr<ResolvedOverload> resolve_overload(JS::VM& vm, IDL::Effect
// 1. Let method be ? GetMethod(V, @@iterator). // 1. Let method be ? GetMethod(V, @@iterator).
// } // }
// method is not undefined, then remove from S all other entries. // method is not undefined, then remove from S all other entries.
else if (value.is_object()
&& has_overload_with_argument_type_or_subtype_matching(overloads, i, [&vm, &method, &value](IDL::Type const& type) {
// - a sequence type
// FIXME: - a frozen array type
// - a nullable version of any of the above types
if (type.name() != "sequence")
return false;
// and after performing the following steps,
// {
// 1. Let method be ? GetMethod(V, @@iterator).
// }
// method is not undefined, then remove from S all other entries.
auto maybe_method = value.get_method(vm, vm.well_known_symbol_iterator());
if (maybe_method.is_error() || maybe_method.value() == nullptr)
return false;
method = *maybe_method.release_value();
return true;
})) {
overloads.remove_all_other_entries();
}
// 10. Otherwise: if Type(V) is Object and there is an entry in S that has one of the following types at position i of its type list, // 10. Otherwise: if Type(V) is Object and there is an entry in S that has one of the following types at position i of its type list,
// - a callback interface type // - a callback interface type
// - a dictionary type // - a dictionary type
@ -375,7 +397,7 @@ JS::ThrowCompletionOr<ResolvedOverload> resolve_overload(JS::VM& vm, IDL::Effect
auto const& callable = overloads.only_item(); auto const& callable = overloads.only_item();
// 14. If i = d and method is not undefined, then // 14. If i = d and method is not undefined, then
if (i == distinguishing_argument_index && method.has_value()) { if (i == distinguishing_argument_index && method) {
// 1. Let V be args[i]. // 1. Let V be args[i].
auto const& value = vm.argument(i); auto const& value = vm.argument(i);

11
Tests/LibWeb/Text/expected/wpt-import/webmessaging/Channel_postMessage_clone_port_error.any.txt Normal file
View file

@ -0,0 +1,11 @@
Summary
Harness status: OK
Rerun
Found 1 tests
1 Pass
Details
Result Test Name MessagePass Test Description: Throw a DataCloneError if transfer array in postMessage contains source port.

15
Tests/LibWeb/Text/input/wpt-import/webmessaging/Channel_postMessage_clone_port_error.any.html Normal file
View file

@ -0,0 +1,15 @@
<!doctype html>
<meta charset=utf-8>
<title>postMessage() DataCloneError: cloning source port</title>
<script>
self.GLOBAL = {
isWindow: function() { return true; },
isWorker: function() { return false; },
isShadowRealm: function() { return false; },
};
</script>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
<div id=log></div>
<script src="../webmessaging/Channel_postMessage_clone_port_error.any.js"></script>

14
Tests/LibWeb/Text/input/wpt-import/webmessaging/Channel_postMessage_clone_port_error.any.js Normal file
View file

@ -0,0 +1,14 @@
// META: title=postMessage() DataCloneError: cloning source port
var description = "Test Description: Throw a DataCloneError if transfer array in postMessage contains source port.";
test(function()
{
var channel = new MessageChannel();
channel.port1.start();
assert_throws_dom("DATA_CLONE_ERR", function()
{
channel.port1.postMessage("ports", [channel.port1]);
});
}, description);