mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-08-06 08:10:02 +00:00
LibGUI: Optimize GUI::Variant move constructor
This commit is contained in:
parent
d0812e9019
commit
4062add8ed
Notes:
sideshowbarker
2024-07-19 01:04:02 +09:00
Author: https://github.com/ccapitalK
Commit: 4062add8ed
Pull-request: https://github.com/SerenityOS/serenity/pull/4315
2 changed files with 11 additions and 3 deletions
|
@ -26,6 +26,7 @@
|
|||
|
||||
#include <AK/FlyString.h>
|
||||
#include <AK/JsonValue.h>
|
||||
#include <AK/RefPtr.h>
|
||||
#include <LibGUI/Variant.h>
|
||||
|
||||
namespace GUI {
|
||||
|
@ -255,10 +256,8 @@ Variant& Variant::operator=(Variant&& other)
|
|||
{
|
||||
if (&other == this)
|
||||
return *this;
|
||||
// FIXME: Move, not copy!
|
||||
clear();
|
||||
copy_from(other);
|
||||
other.clear();
|
||||
move_from(AK::move(other));
|
||||
return *this;
|
||||
}
|
||||
|
||||
|
@ -267,6 +266,14 @@ Variant::Variant(const Variant& other)
|
|||
copy_from(other);
|
||||
}
|
||||
|
||||
void Variant::move_from(Variant&& other)
|
||||
{
|
||||
m_type = other.m_type;
|
||||
m_value = other.m_value;
|
||||
other.m_type = Type::Invalid;
|
||||
other.m_value.as_string = nullptr;
|
||||
}
|
||||
|
||||
void Variant::copy_from(const Variant& other)
|
||||
{
|
||||
ASSERT(!is_valid());
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue