mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-03 17:58:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Make HTML::DecodedImageData to be GC-allocated

Browse source 
This change fixes GC-leak caused by following mutual dependency:
- SVGDecodedImageData owns JS::Handle for Page.
- SVGDecodedImageData is owned by visited objects.
by making everything inherited from HTML::DecodedImageData and
ListOfAvailableImages to be GC-allocated.

Generally, if visited object has a handle, very likely we leak
everything visited from object in a handle.
This commit is contained in:
Aliaksandr Kalenik 2023-12-12 20:07:19 +01:00 • committed by Andreas Kling
parent 57a04c536c
commit 41a3c19cfe
Notes: sideshowbarker 2024-07-17 07:06:47 +09:00
18 changed files with 100 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View file

@ -354,7 +354,7 @@ i32 HTMLObjectElement::default_tab_index_value() const
return 0;
}
RefPtr<DecodedImageData const> HTMLObjectElement::image_data() const
JS::GCPtr<DecodedImageData> HTMLObjectElement::image_data() const
{
if (!m_image_request)
return nullptr;