mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 03:25:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

RequestServer: Remove IPV6 bracket notation on host before resolving

Browse source 
Previously, we were passing in the serialized value which included
square brackets but that isn't a valid IPV6 address.
This commit is contained in:
rmg-x 2025-02-16 16:18:39 -06:00 • committed by Ali Mohammad Pur
parent 23a8bbca01
commit 41c6f93aa8
Notes: github-actions[bot] 2025-02-17 11:03:35 +00:00
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Services/RequestServer/ConnectionFromClient.cpp
View file

@ -353,6 +353,11 @@ void ConnectionFromClient::start_request(i32 request_id, ByteString const& metho
}
auto host = url.serialized_host().to_byte_string();
// Check if host has the bracket notation for IPV6 addresses and remove them
if (host.starts_with("["sv) && host.ends_with("]"sv))
host = host.substring(1, host.length() - 2);
m_resolver->dns.lookup(host, DNS::Messages::Class::IN, { DNS::Messages::ResourceType::A, DNS::Messages::ResourceType::AAAA })
->when_rejected([this, request_id](auto const& error) {
dbgln("StartRequest: DNS lookup failed: {}", error);