mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Make Navigation navigate event trusted
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
Fixes WPT test:

https://wpt.live/navigation-api/navigate-event/signal-abort-intercept.html
This commit is contained in:
Shannon Booth 2025-04-26 15:44:16 +12:00 • committed by Tim Flynn
commit 420949b134
Notes: github-actions[bot] 2025-04-27 11:55:04 +00:00
3 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/HTML/NavigateEvent.cpp
View file

@ -25,6 +25,13 @@ namespace Web::HTML {
GC_DEFINE_ALLOCATOR(NavigateEvent); GC_DEFINE_ALLOCATOR(NavigateEvent);
GC::Ref<NavigateEvent> NavigateEvent::create(JS::Realm& realm, FlyString const& event_name, NavigateEventInit const& event_init)
{
auto event = realm.create<NavigateEvent>(realm, event_name, event_init);
event->set_is_trusted(true);
return event;
}
GC::Ref<NavigateEvent> NavigateEvent::construct_impl(JS::Realm& realm, FlyString const& event_name, NavigateEventInit const& event_init) GC::Ref<NavigateEvent> NavigateEvent::construct_impl(JS::Realm& realm, FlyString const& event_name, NavigateEventInit const& event_init)
{ {
return realm.create<NavigateEvent>(realm, event_name, event_init); return realm.create<NavigateEvent>(realm, event_name, event_init);

1
Libraries/LibWeb/HTML/NavigateEvent.h
View file

@ -52,6 +52,7 @@ public:
Finished Finished
}; };
[[nodiscard]] static GC::Ref<NavigateEvent> create(JS::Realm&, FlyString const& event_name, NavigateEventInit const&);
[[nodiscard]] static GC::Ref<NavigateEvent> construct_impl(JS::Realm&, FlyString const& event_name, NavigateEventInit const&); [[nodiscard]] static GC::Ref<NavigateEvent> construct_impl(JS::Realm&, FlyString const& event_name, NavigateEventInit const&);
// The navigationType, destination, canIntercept, userInitiated, hashChange, signal, formData, downloadRequest, // The navigationType, destination, canIntercept, userInitiated, hashChange, signal, formData, downloadRequest,

2
Libraries/LibWeb/HTML/Navigation.cpp
View file

@ -1045,7 +1045,7 @@ bool Navigation::inner_navigate_event_firing_algorithm(
} }
// AD-HOC: *Now* we have all the info required to create the event // AD-HOC: *Now* we have all the info required to create the event
auto event = NavigateEvent::construct_impl(realm, EventNames::navigate, event_init); auto event = NavigateEvent::create(realm, EventNames::navigate, event_init);
event->set_abort_controller(abort_controller); event->set_abort_controller(abort_controller);
// AD-HOC: This is supposed to be set in "fire a <type> navigate event", and is only non-null when // AD-HOC: This is supposed to be set in "fire a <type> navigate event", and is only non-null when